Skip to content

[OPTIMIZATION] Only center the strumlines once in Blazin' #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+4 −36
Open

[OPTIMIZATION] Only center the strumlines once in Blazin' #248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 4 additions & 36 deletions preload/scripts/songs/blazin.hxc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,30 +18,16 @@ class BlazinSong extends Song
{
super('blazin');

this.hasHidden = false;
this.hasPlayedCutscene = false;
}

function onCreate(event:ScriptEvent):Void
{
super.onCreate(event);

this.hasHidden = false;
this.hasPlayedCutscene = false;
}

function onDestroy(event:ScriptEvent):Void
{
super.onDestroy(event);

this.hasHidden = false;
}

function onNoteHit(event:HitNoteScriptEvent):Void
{
super.onNoteHit(event);
}

public function listDifficulties(variationId:String, variationIds:Array<String>, showLocked:Bool):Array<String>
{
if (showLocked || Save.instance.hasBeatenLevel('weekend1'))
Expand All @@ -53,31 +39,13 @@ class BlazinSong extends Song
return [];
}

var hasHidden = false;
var hasPlayedCutscene:Bool = false;

function onUpdate(event:ScriptEvent):Void
function onCountdownStart(event)
{
super.onUpdate(event);

if (!this.hasHidden)
{
this.hasHidden = true;
hideOpponentStrumline();
centerPlayerStrumline();
}
}

function hideOpponentStrumline()
{
var opponentStrumline:FlxSprite = PlayState.instance.opponentStrumline;
if (opponentStrumline != null)
{
for (arrow in opponentStrumline.members)
{
arrow.visible = false;
}
}
super.onCountdownStart(event);
PlayState.instance.opponentStrumline.visible = false;
centerPlayerStrumline();
}

function centerPlayerStrumline()
Expand Down