GT-56: Add base class for OIDC AuthTokens, add EOSCAAI AuthToken#430
Open
gregcorbett wants to merge 10 commits intoGOCDB:devfrom
Open
GT-56: Add base class for OIDC AuthTokens, add EOSCAAI AuthToken#430gregcorbett wants to merge 10 commits intoGOCDB:devfrom
gregcorbett wants to merge 10 commits intoGOCDB:devfrom
Conversation
This was referenced Feb 17, 2023
gregcorbett
force-pushed
the
eosc_aai_refactor
branch
2 times, most recently
from
9bc132c to
f7c6a0a
Compare
- it's abstract because the idea is that it will be extended by specific, non-abstract, classes - like a token class to handle EOSC AAI.
- currently only supports aai-demo.eosc-portal.eu
gregcorbett
force-pushed
the
eosc_aai_refactor
branch
from
f7c6a0a to
e1c9d77
Compare
Member
Author
|
The codacy / codeclimate issues are being tackled as part of #423. |
gregcorbett
changed the title
rowan04
reviewed
Feb 27, 2023
rowan04
reviewed
Mar 27, 2023
- it was over 80 characters, which PSR12 says we should not do. - it also makes it more consistent with other lines in this file. Co-authored-by: Rowan <rowanmoss04@gmail.com>
rowan04
reviewed
Apr 17, 2023
| /** | ||
| * {@see IAuthentication::eraseCredentials()} | ||
| */ | ||
| public function eraseCredentials() |
Contributor
There was a problem hiding this comment.
Why is this function and validate() function below left blank?
rowan04
reviewed
Apr 17, 2023
| $_SERVER[$this->groupHeader] | ||
| ); | ||
|
|
||
| $presentBadGroups = []; |
Contributor
There was a problem hiding this comment.
should this block of code start with a comment, like in the similar function checkRequiredGroups() above?
Contributor
There was a problem hiding this comment.
saying something like "// Build up a list of banned groups"
rowan04
reviewed
Apr 17, 2023
| null, | ||
| 'You do not belong to the correct group(s) ' . | ||
| 'to gain access to this site.<br /><br />' . $errorContext . | ||
| $prependString . $groupString . '<br /><br />' . $this->helpString |
Contributor
There was a problem hiding this comment.
is $prependString needed here, when $groupString starts with $prependString?
gregcorbett
commented
Jul 31, 2024
| $this->groupSplitChar = ','; | ||
| $this->bannedGroups = array(); | ||
| $this->requiredGroups = array("urn:geant:eosc-portal.eu:res:gocdb.eosc-portal.eu"); | ||
| $this->helpString = 'Please seek assistance by opening a ticket against the ' . |
Member
Author
There was a problem hiding this comment.
Suggested change
| $this->helpString = 'Please seek assistance by opening a ticket against the ' . | |
| $this->helpMessage = 'Please seek assistance by opening a ticket against the ' . |
helpMessage is probably more readable than helpString
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Rather than proliferate
die()calls, the OIDC abstract class throws exceptions which are now handled (granted this handling then callsdie()because it can't make use ofshow_view('error.php',...)This code is running on gocdb-preprod.eosc-portal.eu.
Supersedes #348.