Improve coverage convention #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR improves the SonarQube configuration for coverage analysis by fixing path issues and ensuring proper module exclusion handling.
- Fixed incorrect kover report path that was using an absolute path instead of relative
- Ensured sonarqube plugin is applied before configuration to properly support module exclusion
- Added Kotlin source directories to Android sourcesets for better Sonar analysis coverage
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| plugin/src/main/kotlin/io/getstream/android/coverage/CoverageConfiguration.kt | Fixed kover report path and improved module exclusion by applying sonarqube plugin earlier and using isSkipProject |
| plugin/src/main/kotlin/io/getstream/android/BaseConfiguration.kt | Added Kotlin source directories to Android sourcesets for Sonar analysis |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aleksandar-apostolov
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had the idea to test the sonar configuration by publishing the analysis in a local sonarqube instance and found a couple of things to improve:
/)isSkipProjectfor properly excluding modules from sonar analysis