Skip to content

Improve coverage convention #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aleksandar-apostolov merged 1 commit into from
Nov 25, 2025
Merged

Improve coverage convention #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions plugin/src/main/kotlin/io/getstream/android/BaseConfiguration.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ internal inline fun <reified Ext : CommonExtension<*, *, *, *, *, *>> Project.co
all(Test::configureTestLogging)
}
}

// Add Kotlin source directories to Android source sets. Useful, for example, for letting
// them being picked up in Sonar analyses.
sourceSets { all { java.srcDir("src/$name/kotlin") } }
}

tasks.withType<JavaCompile>().configureEach {
Expand Down
7 changes: 4 additions & 3 deletions plugin/src/main/kotlin/io/getstream/android/coverage/CoverageConfiguration.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ private fun Project.configureSonar(extension: StreamProjectExtension) {
property(
"sonar.coverage.jacoco.xmlReportPaths",
layout.buildDirectory
.file("/reports/kover/report${KoverConstants.VARIANT_SUFFIX}.xml")
.file("reports/kover/report${KoverConstants.VARIANT_SUFFIX}.xml")
.get(),
)
}
Expand All @@ -103,13 +103,14 @@ private fun Project.setupKoverDependencyOnModules(includedModules: Set<String>)
internal fun Project.configureCoverageModule() {
val coverageOptions = requireStreamProjectExtension().coverage

pluginManager.apply("org.sonarqube")

// Only configure coverage for included modules
if (name !in coverageOptions.includedModules.get()) {
extensions.configure<SonarExtension> { isSkipProject = true }
return
}

pluginManager.apply("org.sonarqube")

// Configure Android test coverage if this is an Android module
pluginManager.withPlugin("com.android.library") { configureAndroid<LibraryExtension>() }
pluginManager.withPlugin("com.android.application") { configureAndroid<ApplicationExtension>() }
Expand Down
Loading