deps: update code for x_orientation for new pyuvdata 3.2#433
Open
steven-murray wants to merge 4 commits intomainfrom
Open
deps: update code for x_orientation for new pyuvdata 3.2#433steven-murray wants to merge 4 commits intomainfrom
steven-murray wants to merge 4 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
==========================================
- Coverage 96.14% 96.11% -0.04%
==========================================
Files 19 19
Lines 6350 6351 +1
==========================================
- Hits 6105 6104 -1
- Misses 245 247 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adeliegorce
reviewed
Apr 7, 2026
Contributor
adeliegorce
left a comment
adeliegorce
left a comment
There was a problem hiding this comment.
Thank you for these changes that were long overdue @steven-murray. Will approve the PR once the tests pass (which is independent from the x_orientation changes I believe).
Contributor
There was a problem hiding this comment.
Some version compatibility issues in the tests following the changes... :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates access to the
.x_orientationattribute in line with recent pyuvdata updates.