-
Notifications
You must be signed in to change notification settings - Fork 73
Jazzy for pr safety #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yguel
wants to merge
12
commits into
ICube-Robotics:jazzy
Choose a base branch
from
yguel:jazzy-for-pr-safety
base: jazzy
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Jazzy for pr safety #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix warnings: no more warnings when compiling. Fix warnings Remove warnings. Fix formatting Finish fixing warnings. Fix memory leak in exception catching. Reformat according to ament_uncrustify. Fix memory leak in exception catching. Finish fixing memory-leak Fix error in memory leak fix. [skip CI] [WIP] safety Fix memory leak in exception catching. First step for safety prototype. Parse the safety_estop.ros2_control.xacro correctly. [WIP] Automatic update of config file path by cmake for testing. [WIP] [WIP] Safety almost done. [WIP] Safety almost done. Change fsoe_config to YAML file YAML modification: tests pass. Set registerTransferInDomain after activating master. [skip ci] [WIP] All test passes. Add documentation in progress for safety. Add safety doc Update doc in safety code Add printing for place in process data from a slave position,index,sub_index Better output for slave operational info. Add binary option to display frames. Example of displaying just control_word and control_status for debugging [Bad] add finishProcessData virtual method to test our hypothesis. Add skip word in EcGenericSlave config. Fix bug to access pdos in generic_ec_cia402_drive Fix bug to access pdos in generic_ec_cia402_drive Let us have state_interfaces in rpdos and command interfaces in tpdos and in any kind of domain map we suppose we can have both. Remove logs for control word. [WIP] Major refactoring of ec_pdo_channel_manager to handle group of interfaces associated with a single PDO [WIP] Major refactoring of ec_pdo_channel_manager to handle group of interfaces associated with a single PDO day 2 [WIP] compile but do not link [WIP] Compile and links ok [WIP] Tests ok, warning one test check has been changed. TODO: check change in operation. [WIP] Add loadConfig group test. [WIP] Update example [WIP] Add more tests that pass [WIP] Fix linter. [WIP] Good output Improve tests for ec_pdo_channel_manager Refactoring: only one master incorporating transfers, renaming safety elements to transfer elements Remove standard outputs, every message is now output on the EthercatDriver message logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.