Fix compatibility with MySQL 8.0.0 to 8.0.13 #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SESSION_VARIABLES_ADMIN wasn't actually introduced in MySQL 8.0.0 but only in 8.0.14.[^1] Use exactly that version in the version comparison to ensure compatibility. [^1]: https://dev.mysql.com/doc/refman/8.0/en/privileges-provided.html#priv_session-variables-admin
oxzi
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SESSION_VARIABLES_ADMINwasn't actually introduced in MySQL 8.0.0 but only in 8.0.14.1 Use exactly that version in the version comparison to ensure compatibility.Tests
Running the Icinga DB integration tests with the following environment variables set:
ICINGA_TESTING_MYSQL_IMAGE=mysql:8.0.0ICINGA_TESTING_MYSQL_IMAGE=mysql:8.0.13ICINGA_TESTING_MYSQL_IMAGE=mysql:8.0.14Before
Running in Icinga DB as-is:
8.0.0:
8.0.13 (yes, the error message got worse):
8.0.14 works fine.
After
After adding
replace github.com/icinga/icinga-testing => ../../icinga-testingto https://github.com/Icinga/icingadb/blob/main/tests/go.mod to use the changed version from this PR: all three versions work fine.refs Icinga/icingadb#729 (the problem was noticed there)
Footnotes
https://dev.mysql.com/doc/refman/8.0/en/privileges-provided.html#priv_session-variables-admin ↩