Integration tests: include MariaDB as well

[Al2Klimov]

just to be sure we're compatible with this RDBMS and not only MySQL.

[oxzi]

Having another test named mysql actually being MariaDB is a bit confusing. Why not setting the name to what it is and introduce another field matching ICINGADB_TESTS_DATABASE_TYPE, e.g., database_type?

[julianbrost]

Please have a look at https://github.com/Icinga/icingadb/blob/main/.github/workflows/sql.yml. This also avoids setting variables like ICINGA_TESTING_PGSQL_IMAGE: mysql:latest.

[Al2Klimov]

Yes, a such env var is a bit cheaty, but I prefer a nice looking matrix with the DB type written just one (lowercase).

[julianbrost]

Yes, a such env var is a bit cheaty,

And setting ICINGA_TESTING_PGSQL_IMAGE: mysql:latest is not cheaty at all?

but I prefer a nice looking matrix with the DB type written just one

You mean once? https://github.com/Icinga/icingadb/blob/main/.github/workflows/sql.yml doesn't repeat it any more than the current version of this PR.

(lowercase).

That sounds just like an arbitrary choice. Sure, if both were otherwise identical, I'd also pick lowercase, but they aren't: it's easier to make the string lowercase in our Go code than in GitHub Actions Workflow YAML. And I don't think "I prefer lowercase" is a reasonable argument to completely rule out the alternative.

[Al2Klimov]

No, setting such an env var IS cheaty of course (as I said), but I prefer it over

• having to lower/upper-case something somewhere
• having to repeat the database type more than once in the matrix

[lippserd]

Please have a look at https://github.com/Icinga/icingadb/blob/main/.github/workflows/sql.yml. This also avoids setting variables like ICINGA_TESTING_PGSQL_IMAGE: mysql:latest.

I don't understand why it is not done exactly as in the referenced file.

[oxzi]

With this change, the debug log from MariaDB and MySQL are having the same filename now. I would advise to revert this.

[oxzi]

While this PR was somewhat forgotten, I just thought about it in spite of #947. How about testing both the latest version as well as the minimum required version for each DBMS?

[Al2Klimov]

They're either not available or don't work and it's a bit out of scope here.

[julianbrost]

They're either not available or don't work and it's a bit out of scope here.

I wouldn't understand that comment if I didn't happen to look at this PR and it's pipelines at just the right moment by pure chance, i.e. at this run: https://github.com/Icinga/icingadb/actions/runs/17097225377

One job failed because there seems to be no mariadb:10.2.2 image on Docker Hub:

panic: Error response from daemon: manifest for mariadb:10.2.2 not found: manifest unknown: manifest unknown

The other one failed with a MySQL error:

panic: Error 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'ON . TO u1 */' at line 1

This also needs more context: that's an error from the database setup done by icinga-testing.

[julianbrost]

Fixing that is trivial actually (if you know where to look), so I just created a PR for it: Icinga/icinga-testing#32