Skip to content

Integration tests: include MariaDB as well #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Integration tests: include MariaDB as well #729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66a5d6d
Integration tests: use more descriptive matrix variable names
Al2Klimov Apr 5, 2024
32dc47b
Integration tests: include MariaDB as well
Al2Klimov Apr 5, 2024
7b80229
tests/: bump github.com/icinga/icinga-testing
Al2Klimov Sep 15, 2025
36f9068
Integration tests: include minimum required RDBMS versions
Al2Klimov Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,27 @@ jobs:
fail-fast: false
matrix:
database:
- name: mysql
pretty_name: MySQL
- name: pgsql
pretty_name: PostgreSQL
- name: MySQL
type: MYSQL
image: mysql:latest
- name: MySQL (minimum required version)
type: MYSQL
image: mysql:8.0.0
- name: MariaDB
type: MYSQL
image: mariadb:latest
- name: MariaDB (minimum required version)
type: MYSQL
# Actually we support v10.2.2+, but Docker Hub doesn't.
image: mariadb:10.2.5
- name: PostgreSQL
type: PGSQL
image: postgres:latest
- name: PostgreSQL (minimum required version)
type: PGSQL
image: postgres:9.6.0

name: ${{ matrix.database.pretty_name }}
name: ${{ matrix.database.name }}
runs-on: ubuntu-latest

steps:
Expand All @@ -40,7 +55,8 @@ jobs:
- name: Run Integration Tests
run: ./icingadb-test -icingatesting.debuglog debug.log -test.v
env:
ICINGADB_TESTS_DATABASE_TYPE: ${{ matrix.database.name }}
ICINGADB_TESTS_DATABASE_TYPE: ${{ matrix.database.type }}
ICINGA_TESTING_${{ matrix.database.type }}_IMAGE: ${{ matrix.database.image }}
ICINGA_TESTING_ICINGADB_BINARY: ${{ github.workspace }}/icingadb
ICINGA_TESTING_ICINGADB_SCHEMA_MYSQL: ${{ github.workspace }}/schema/mysql/schema.sql
ICINGA_TESTING_ICINGADB_SCHEMA_PGSQL: ${{ github.workspace }}/schema/pgsql/schema.sql
Expand Down
2 changes: 1 addition & 1 deletion tests/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ require (
github.com/goccy/go-yaml v1.13.0
github.com/google/uuid v1.6.0
github.com/icinga/icinga-go-library v0.7.2
github.com/icinga/icinga-testing v0.0.0-20240322142451-494ccd6d03e8
github.com/icinga/icinga-testing v0.0.0-20250901101810-43491aa4f931
github.com/jmoiron/sqlx v1.4.0
github.com/lib/pq v1.10.9
github.com/redis/go-redis/v9 v9.14.0
Expand Down
4 changes: 2 additions & 2 deletions tests/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ github.com/grpc-ecosystem/grpc-gateway/v2 v2.20.0 h1:bkypFPDjIYGfCYD5mRBvpqxfYX1
github.com/grpc-ecosystem/grpc-gateway/v2 v2.20.0/go.mod h1:P+Lt/0by1T8bfcF3z737NnSbmxQAppXMRziHUxPOC8k=
github.com/icinga/icinga-go-library v0.7.2 h1:6ilUeE9F9OqxxJXNR9URWDf6zOqsdhjjR9w1MUXY9Kg=
github.com/icinga/icinga-go-library v0.7.2/go.mod h1:HZTiYD+N+9FZIVpPdUEJWJnc6sLvrIRO03jvkdkmUEU=
github.com/icinga/icinga-testing v0.0.0-20240322142451-494ccd6d03e8 h1:PI+39IY1BjN24JC3B6Jy0rhwm3hqC4SnQFxbZjXOaHk=
github.com/icinga/icinga-testing v0.0.0-20240322142451-494ccd6d03e8/go.mod h1:xjNiwePgnSVKJWPG/iFG7pNOibU/OWp01Zdl08o+EeI=
github.com/icinga/icinga-testing v0.0.0-20250901101810-43491aa4f931 h1:YdZ7XuBVbGimF1zrZq/y7y7faLb2CzbccVzHzHdRODY=
github.com/icinga/icinga-testing v0.0.0-20250901101810-43491aa4f931/go.mod h1:xjNiwePgnSVKJWPG/iFG7pNOibU/OWp01Zdl08o+EeI=
github.com/jmoiron/sqlx v1.4.0 h1:1PLqN7S1UYp5t4SrVVnt4nUVNemrDAtxlulVe+Qgm3o=
github.com/jmoiron/sqlx v1.4.0/go.mod h1:ZrZ7UsYB/weZdl2Bxg6jCRO9c3YHl8r3ahlKmRT4JLY=
github.com/kisielk/errcheck v1.5.0/go.mod h1:pFxgyoBC7bSaBwPgfKdkLd5X25qrDl4LWUI2bnpBCr8=
Expand Down
Loading