menu.less: Apply same bg-color to the caret in the .nav-item-header
#5375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
force-pushed
the
fix/menu-hover-caret-color
branch
from
a2e2a35 to
fe6d568
Compare
nilmerg
reviewed
Jun 4, 2025
| height: @nav-item-height; | ||
| line-height: @nav-item-height; | ||
| display: block; | ||
| #layout:not(.minimal-layout).sidebar-collapsed #menu .nav-level-1 > .nav-item.hover > .nav-level-2 { |
Contributor
Author
There was a problem hiding this comment.
Otherwise, the color of the caret (:after) cannot be changed, as it has been defined with higher specificity (:not.minimal-layout). I have used the same specificity to change the color.
And the caret and the .nav-item-header are not present in the .minimal-layout. So this change cannot have a negative effect.
sukhwinder33445
force-pushed
the
fix/menu-hover-caret-color
branch
from
fe6d568 to
0170600
Compare
- Change the css specificity so it matches the existing level (hovered menu)
sukhwinder33445
force-pushed
the
fix/menu-hover-caret-color
branch
from
0170600 to
8997f7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After: