Skip to content

menu.less: Apply same bg-color to the caret in the .nav-item-header #5375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sukhwinder33445 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

menu.less: Apply same bg-color to the caret in the .nav-item-header #5375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 22 additions & 16 deletions public/css/icinga/menu.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,25 +533,31 @@ html.no-js #toggle-sidebar {
margin-right: 0;
}

#layout.sidebar-collapsed #menu .nav-level-1 > .nav-item.hover .nav-level-2 > .nav-item-header {
background-color: @menu-bg-color;
color: @menu-color;
border-bottom: 1px solid @gray-light;
border-top-left-radius: .25em;
border-top-right-radius: .25em;
#layout:not(.minimal-layout).sidebar-collapsed #menu .nav-level-1 > .nav-item.hover > .nav-level-2 {
Copy link
Member

@nilmerg nilmerg Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why :not(.mimimal-layout)?

Copy link
Contributor Author

@sukhwinder33445 sukhwinder33445 Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, the color of the caret (:after) cannot be changed, as it has been defined with higher specificity (:not.minimal-layout). I have used the same specificity to change the color.
And the caret and the .nav-item-header are not present in the .minimal-layout. So this change cannot have a negative effect.

&:not(.bottom-up)::after {
background-color: @menu-bg-color;
}

span {
padding-left: 1.375em;
padding-right: 0.545em;
height: @nav-item-height;
line-height: @nav-item-height;
display: block;
.nav-item-header {
background-color: @menu-bg-color;
color: @menu-color;
border-bottom: 1px solid @gray-light;
border-top-left-radius: .25em;
border-top-right-radius: .25em;

span {
padding-left: 1.375em;
padding-right: 0.545em;
height: @nav-item-height;
line-height: @nav-item-height;
display: block;

font-weight: @font-weight-bold;
.text-ellipsis();
font-weight: @font-weight-bold;
.text-ellipsis();

> .badge {
display: none;
> .badge {
display: none;
}
}
}
}
Expand Down
Loading