feat: Modal disconnect from account details#181
Merged
Conversation
…ion string resources
There was a problem hiding this comment.
Pull request overview
This PR introduces a new 2-step “disconnect/remove account” flow launched from the Account Details screen, implemented as Navigation3 dialog destinations with new warning/confirmation dialogs and updated localized strings.
Changes:
- Added disconnect/remove warning + confirmation dialogs and wired them into the Navigation3 back stack (DialogSceneStrategy).
- Extended
AccountDetailsUiState.Successwith a disconnect configuration to drive dialog content (titles/descriptions/buttons/URLs). - Updated strings across multiple locales and added a new info icon vector.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
gradle/libs.versions.toml |
Bumps Navigation3 core version to support dialog scene strategy usage. |
app/src/main/res/values/strings.xml |
Adds new disconnect/remove labels and warning copy (EN). |
app/src/main/res/values-sv/strings.xml |
Adds Swedish translations for new disconnect/remove strings. |
app/src/main/res/values-pt/strings.xml |
Adds Portuguese translations for new disconnect/remove strings. |
app/src/main/res/values-pl/strings.xml |
Adds Polish translations for new disconnect/remove strings. |
app/src/main/res/values-nl/strings.xml |
Adds Dutch translations for new disconnect/remove strings. |
app/src/main/res/values-nb/strings.xml |
Adds Norwegian Bokmål translations for new disconnect/remove strings. |
app/src/main/res/values-it/strings.xml |
Adds Italian translations for new disconnect/remove strings. |
app/src/main/res/values-fr/strings.xml |
Adds French translations for new disconnect/remove strings. |
app/src/main/res/values-fi/strings.xml |
Adds Finnish translations for new disconnect/remove strings. |
app/src/main/res/values-es/strings.xml |
Adds Spanish translations for new disconnect/remove strings. |
app/src/main/res/values-el/strings.xml |
Adds Greek translations for new disconnect/remove strings. |
app/src/main/res/values-de/strings.xml |
Adds German translations for new disconnect/remove strings. |
app/src/main/res/values-da/strings.xml |
Adds Danish translations for new disconnect/remove strings. |
app/src/main/res/drawable/ic_circle_information_outlined.xml |
Adds a new info icon used in the warning dialog. |
app/src/main/kotlin/com/infomaniak/auth/ui/screen/main/MainScreen.kt |
Registers DialogSceneStrategy with NavDisplay to render dialog destinations. |
app/src/main/kotlin/com/infomaniak/auth/ui/screen/accountdetails/AccountDetailsViewModel.kt |
Builds a disconnect configuration in UI state and changes account removal behavior. |
app/src/main/kotlin/com/infomaniak/auth/ui/screen/accountdetails/AccountDetailsScreen.kt |
Routes “disconnect/remove” click to navigation with the computed configuration and updates button label for NotConnected. |
app/src/main/kotlin/com/infomaniak/auth/ui/navigation/NavigationEntryProvider.kt |
Adds dialog entries and navigation transitions for warning/confirmation dialogs. |
app/src/main/kotlin/com/infomaniak/auth/ui/navigation/NavDestination.kt |
Adds new dialog destinations for disconnect warning/confirmation. |
app/src/main/kotlin/com/infomaniak/auth/ui/components/dialog/DisconnectWarningDialog.kt |
New warning dialog UI, including “check methods/add step” action. |
app/src/main/kotlin/com/infomaniak/auth/ui/components/dialog/DisconnectConfirmDialog.kt |
New confirmation dialog UI that triggers the configured confirm action. |
Comments suppressed due to low confidence (1)
app/src/main/kotlin/com/infomaniak/auth/ui/screen/accountdetails/AccountDetailsScreen.kt:281
- The preview passes
onRemoveAccountClicked = {}but the parameter type is(DisconnectConfiguration) -> Unit. This won’t compile because the lambda is missing the required parameter. Update the preview to accept (and ignore) the parameter.
AccountDetailsScreen(
uiState = { AccountDetailsUiState.Success(
account = accountPairs.first,
user = accountPairs.second,
disconnectConfiguration = DisconnectConfiguration.DisconnectSecuredAccount(
onConfirmButton = {},
accessToken = "fake_access_token",
)
) },
onLoginPressed = {},
onBackPressed = {},
onChallengesRefreshClicked = {},
onRemoveAccountClicked = {},
)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
This PR/issue depends on:
|
tevincent
approved these changes
May 18, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modal disconnect from account details
Depends on #176