Skip to content

Address all sanity issues #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

Ruchip16
Copy link

@Ruchip16 Ruchip16 commented Jul 18, 2025

This PR addresses and resolves multiple sanity test failures raised by ansible-test sanity for the juniper.device collection.

  • Fixes import error by replacing ansible.errors with allowed ansible.module_utils.errors.
  • Updates runtime.yml to reflect correct dependencies for netcommon usage.

Tested with ansible-test sanity on Python 3.12.

Ref: https://github.com/chidanandpujar/documentation_steps/blob/main/ansible_sanity_failures

@Ruchip16 Ruchip16 requested a review from rohitthakur2590 July 22, 2025 11:42
@chidanandpujar
Copy link
Collaborator

Hi @Ruchip16,
Thanks for the sanity fixes.
I have merged the changes to branch https://github.com/Juniper/ansible-junos-stdlib/tree/jnpr-ansible-merger.

Please feel re-open or submit fixes, if you find anything is missing in the merged branch https://github.com/Juniper/ansible-junos-stdlib/tree/jnpr-ansible-merger.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants