Address all sanity issues

.gitignore

@@ -56,3 +56,6 @@ desktop.ini
 
 # VC Code
 .vscode
+ansible_collections/ansible
+ansible_collections/ansible.netcommon-8.0.1.info
+ansible_collections/ansible.utils-6.0.0.info

ansible_collections/juniper/device/meta/runtime.yml

@@ -1,6 +1,6 @@
+---
 requires_ansible: ">=2.17.0"
 plugin_routing:
-  plugins:
   modules:
     hostname:
       redirect: juniper.device.junos_hostname
@@ -44,8 +44,15 @@ plugin_routing:
       redirect: juniper.device.junos_routing_instances
     routing_options:
       redirect: juniper.device.junos_routing_options
-    routing_options:
-      redirect: juniper.device.junos_routing_options
+    scp:
+      redirect: juniper.device.junos_scp
+      deprecation:
+        removal_date: "2025-01-01"
+        warning_text: See the plugin documentation for more details
+    junos_scp:
+      deprecation:
+        removal_date: "2025-01-01"
+        warning_text: See the plugin documentation for more details
     security_policies:
       redirect: juniper.device.junos_security_policies
     security_policies_global:

ansible_collections/juniper/device/plugins/action/hostname.py

@@ -0,0 +1 @@
+junos.py

ansible_collections/juniper/device/plugins/action/junos.py

@@ -44,7 +44,7 @@
 
 class ActionModule(ActionNetworkModule):
     def run(self, tmp=None, task_vars=None):
-        
+
         del tmp  # tmp no longer has any effect
 
         module_name = self._task.action.split(".")[-1]
@@ -56,7 +56,7 @@ def run(self, tmp=None, task_vars=None):
         if self._play_context.connection == "local":
             provider = load_provider(junos_provider_spec, self._task.args)
             pc = copy.deepcopy(self._play_context)
-            #pc.network_os = "juniper.device.junos"
+            # pc.network_os = "juniper.device.junos"
             pc.network_os = "juniper.device.device"
             pc.remote_addr = provider["host"] or self._play_context.remote_addr
 

ansible_collections/juniper/device/plugins/action/junos_facts.py

@@ -44,12 +44,11 @@
 
 class ActionModule(ActionNetworkModule):
     def run(self, tmp=None, task_vars=None):
-
         del tmp  # tmp no longer has any effect
 
         module_name = self._task.action.split(".")[-1]
-        #module_name = "device_facts"
-        #self._task.action = "device_facts"
+        # module_name = "device_facts"
+        # self._task.action = "device_facts"
         self._task.collections.append("juniper.device")
         self._config_module = True if module_name in ["junos_config", "config"] else False
         persistent_connection = self._play_context.connection.split(".")[-1]