Refactor Non-Interactive Proofs to use type NiProof#154
Merged
survived merged 3 commits intoLFDT-Lockness:cggmp24/mfrom Aug 28, 2025
Merged
Refactor Non-Interactive Proofs to use type NiProof#154survived merged 3 commits intoLFDT-Lockness:cggmp24/mfrom
survived merged 3 commits intoLFDT-Lockness:cggmp24/mfrom
Conversation
Signed-off-by: jfdreis <josevtnreis@gmail.com>
maurges
reviewed
Aug 26, 2025
maurges
reviewed
Aug 26, 2025
maurges
reviewed
Aug 26, 2025
maurges
reviewed
Aug 26, 2025
Contributor
|
Thanks for the patch, I left a couple of notes |
Signed-off-by: jfdreis <josevtnreis@gmail.com>
maurges
previously approved these changes
Aug 27, 2025
Signed-off-by: jfdreis <josevtnreis@gmail.com>
survived
approved these changes
Aug 28, 2025
Contributor
survived
left a comment
survived
left a comment
There was a problem hiding this comment.
Looks great, thank you!
Just a little remark for future PRs: I'd say that it's preferable to write ni_proof instead of niproof, it'd be more correct translation from camel case NiProof
This was referenced Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially addresses one of the TODOs in CGGMP24 TODOs:
Refactoring Non Interactive Proofs such that they accept
type NiProof = (Commitment, Proof)Currently, this change has been applied to the Non-Interactive ZK-proof of Paillier-Blum modulus.