VDR: Accumulate draws from secondaries #2607
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
CI gfxreconstruct build queued with queue ID 624429. |
Collaborator
|
CI gfxreconstruct build # 8616 running. |
Collaborator
|
CI gfxreconstruct build # 8616 passed. |
panos-lunarg
force-pushed
the
VDR_draws_from_secondaries
branch
from
e717fa1 to
90ed255
Compare
Collaborator
|
CI gfxreconstruct build queued with queue ID 624567. |
Collaborator
|
CI gfxreconstruct build # 8617 running. |
Collaborator
|
CI gfxreconstruct build # 8617 passed. |
Currently each primary in CmdExecuteCommands executes its corresponding command buffer from the secondary context. In practice this means that each secondary is essentially run in isolation from the other secondaries which causes incorrect renderings. This commit addresses this by progressively accumulating command buffer from each secondary so that previous secondaries are send for execution along with subsequent ones from the same execute commands.
panos-lunarg
force-pushed
the
VDR_draws_from_secondaries
branch
from
90ed255 to
589d8db
Compare
Collaborator
|
CI gfxreconstruct build queued with queue ID 624664. |
Collaborator
|
CI gfxreconstruct build # 8620 running. |
Collaborator
|
CI gfxreconstruct build # 8620 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently each primary in CmdExecuteCommands executes its corresponding command buffer from the secondary context. In practice this means that each secondary is essentially run in isolation from the other secondaries which causes incorrect renderings.
This commit addresses this by progressively accumulating command buffer from each secondary so that previous secondaries are send for execution along with subsequent ones from the same execute commands.