Fix vm explorer url - #10244
Open
GilbertCherrie wants to merge 7 commits into
Open
Conversation
Member
|
What happens if someone passes garbarge, for example |
Member
Author
@Fryguy it errors out like this |
Member
Author
|
@Fryguy I pushed a fix so that bad urls are handled better: |
Member
|
A few things -
|
GilbertCherrie
force-pushed
the
fix-vm-explorer-url
branch
3 times, most recently
from
August 24, 2026 17:28
88aa546 to
0e154cf
Compare
GilbertCherrie
force-pushed
the
fix-vm-explorer-url
branch
from
August 24, 2026 17:30
0e154cf to
aa59016
Compare
Member
|
Checked commits GilbertCherrie/manageiq-ui-classic@791787d~...a1a229c with ruby 3.3.10, rubocop 1.88.2, haml-lint 0.76.0, and yamllint 1.37.1 app/controllers/storage_controller.rb
app/controllers/vm_common.rb
|
Member
Author
|
@Fryguy I fixed the explorers that needed fixing in this PR. The other explorers can't seem to be fixed as they work inherently differently. I asked AI to come up with an explanation on why they can't be fixed and a summary is: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes: #6696
Fixes an issue where trying to access URLs related to the VMs:
/vm_or_template/explorer/:id/vm_cloud/explorer/:id/vm_infra/explorer/:idthrows an error. This PR fixes this issue and now the page correctly redirects to the correct record.
This PR also fixes the redirect for the storage explorer and catalog explorer with example URLS:
/storage/explorer/:id/catalog/explorer/:idor/catalog/ot_show/:id(Orchestration templates only, this path already exists on master)Other explorer fixes:
/miq_ae_class/show/:id(This path already exists on master, this PR just fixes the page)/miq_ae_customization/editor/:id(This path already exists on master, this PR just fixes the error handling of a bad URL)Note: The catalog controller only supports the catalog item and orchestration item templates. You can not use raw IDs to direct to service catalogs or catalogs.
Before:

After:
