Fix AutoPlaylist race condition with AutoChange preset applications #264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a race condition where AutoPlaylist would disable itself when AutoChange applied presets, interpreting them as manual user changes.
Problem
When both AutoPlaylist and AutoChange are enabled, AutoPlaylist would sometimes disable itself with the message:
This occurred because:
applyPreset(id, CALL_MODE_NOTIFICATION)
applyPreset(newpreset)
without specifying a call modeSolution
The fix ensures both AutoPlaylist and AutoChange use the same call mode by changing:
applyPreset(newpreset);
to:
applyPreset(newpreset, CALL_MODE_NOTIFICATION);
This makes both systems use
CALL_MODE_NOTIFICATION
, ensuring consistency and preventing AutoPlaylist from misinterpreting AutoChange actions as manual interventions.Testing
changePlaylist()
behaviorFixes #256.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.registry.nm1.platformio.org
/usr/bin/python3 /home/REDACTED/.local/bin/pio run --list-targets
(dns block)api.registry.platformio.org
/usr/bin/python3 /home/REDACTED/.local/bin/pio run --list-targets
(dns block)collector.platformio.org
/usr/bin/python3 /home/REDACTED/.local/bin/pio run --list-targets
(dns block)wled00
node tools/cdata.js
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.