Skip to content

Fix AutoPlaylist race condition with AutoChange preset applications #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: mdev
Choose a base branch
from
Draft

Fix AutoPlaylist race condition with AutoChange preset applications #264

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a01b58
Initial plan
Copilot Sep 20, 2025
49a1399
Fix AutoPlaylist race condition: use CALL_MODE_NOTIFICATION for AutoC…
Copilot Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion usermods/usermod_v2_auto_playlist/usermod_v2_auto_playlist.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ class AutoPlaylistUsermod : public Usermod {
// after change_lockout. Better for smaller change_lockout values.

suspendPlaylist(); // suspend the playlist engine before changing to another preset
applyPreset(newpreset);
applyPreset(newpreset, CALL_MODE_NOTIFICATION);

#ifdef USERMOD_AUTO_PLAYLIST_DEBUG
USER_PRINTF("*** CHANGE distance = %4lu - change_interval was %5ldms - next change_threshold is %4u (%4u diff aprox)\n",(unsigned long)distance,change_interval,change_threshold,change_threshold_change);
Expand Down