💥 Remove PropertyName typed IterateeShorthand#228
Merged
yujeong-jeon merged 4 commits intomainfrom Mar 12, 2025
Merged
Conversation
yujeong-jeon
changed the title
PropertyName typed IterateeShorthand
Collaborator
✅ Changeset detectedLatest commit: 4425908
If no version change is needed, please add The changes in this PR will be included in the next version bump. powered by: naverpay changeset detect-add actions |
Contributor
Benchmark Results
View Full Benchmark Data{
"files": [
{
"filepath": "/home/runner/work/hidash/hidash/src/every.bench.ts",
"groups": [
{
"fullName": "src/every.bench.ts > every performance",
"benchmarks": [
{
"id": "-686471173_0_0",
"name": "hidash",
"rank": 1,
"rme": 6.692261186522777,
"samples": [],
"totalTime": 512.273788,
"min": 19.540376999999978,
"max": 34.25593100000003,
"hz": 44.89786621680514,
"period": 22.272773391304348,
"mean": 22.272773391304348,
"variance": 11.879678664714254,
"sd": 3.4466909731965023,
"sem": 0.7186847487118775,
"df": 22,
"critical": 2.074,
"moe": 1.4905521688284338,
"p75": 24.227112999999974,
"p99": 34.25593100000003,
"p995": 34.25593100000003,
"p999": 34.25593100000003,
"sampleCount": 23,
"median": 20.382491999999957
},
{
"id": "-686471173_0_1",
"name": "lodash",
"rank": 2,
"rme": 0.6315864194869932,
"samples": [],
"totalTime": 509.84216800000013,
"min": 36.18657099999996,
"max": 37.7668970000002,
"hz": 27.459478400774408,
"period": 36.41729771428572,
"mean": 36.41729771428572,
"variance": 0.1587455400862712,
"sd": 0.398428839425902,
"sem": 0.10648458643869249,
"df": 13,
"critical": 2.16,
"moe": 0.2300067067075758,
"p75": 36.406473000000005,
"p99": 37.7668970000002,
"p995": 37.7668970000002,
"p999": 37.7668970000002,
"sampleCount": 14,
"median": 36.29117199999996
}
]
}
]
},
{
"filepath": "/home/runner/work/hidash/hidash/src/filter.bench.ts",
"groups": [
{
"fullName": "src/filter.bench.ts > filter performance",
"benchmarks": [
{
"id": "-1531020664_0_0",
"name": "hidash",
"rank": 1,
"rme": 1.3393501865348088,
"samples": [],
"totalTime": 580.8914139999995,
"min": 57.459904999999935,
"max": 61.09159599999998,
"hz": 17.214921341564207,
"period": 58.089141399999946,
"mean": 58.089141399999946,
"variance": 1.1830224834147363,
"sd": 1.0876683701453933,
"sem": 0.3439509388582529,
"df": 9,
"critical": 2.262,
"moe": 0.778017023697368,
"p75": 58.14276099999984,
"p99": 61.09159599999998,
"p995": 61.09159599999998,
"p999": 61.09159599999998,
"sampleCount": 10,
"median": 57.68141000000003
},
{
"id": "-1531020664_0_1",
"name": "lodash",
"rank": 2,
"rme": 1.1731556296311598,
"samples": [],
"totalTime": 2280.47982,
"min": 222.43596300000036,
"max": 233.75591200000054,
"hz": 4.385042091712085,
"period": 228.047982,
"mean": 228.047982,
"variance": 13.988737602471792,
"sd": 3.7401520827998147,
"sem": 1.1827399377070087,
"df": 9,
"critical": 2.262,
"moe": 2.6753577390932537,
"p75": 231.2115749999998,
"p99": 233.75591200000054,
"p995": 233.75591200000054,
"p999": 233.75591200000054,
"sampleCount": 10,
"median": 226.91996400000016
}
]
}
]
},
{
"filepath": "/home/runner/work/hidash/hidash/src/findIndex.bench.ts",
"groups": [
{
"fullName": "src/findIndex.bench.ts > findIndex performance",
"benchmarks": [
{
"id": "-41870147_0_0",
"name": "hidash",
"rank": 1,
"rme": 0.7602550740064136,
"samples": [],
"totalTime": 500.07395499999575,
"min": 0.18465500000002066,
"max": 1.1169889999999896,
"hz": 4977.263812909475,
"period": 0.20091360184813006,
"mean": 0.20091360184813006,
"variance": 0.001511645959374764,
"sd": 0.03887989145271324,
"sem": 0.0007793142104180879,
"df": 2488,
"critical": 1.96,
"moe": 0.0015274558524194523,
"p75": 0.19725900000003094,
"p99": 0.32863399999996545,
"p995": 0.4237920000000486,
"p999": 0.8172589999999786,
"sampleCount": 2489,
"median": 0.1908369999999877
},
{
"id": "-41870147_0_1",
"name": "lodash",
"rank": 2,
"rme": 0.3747370269929244,
"samples": [],
"totalTime": 500.6776510000002,
"min": 0.9794819999999618,
"max": 1.3780980000000227,
"hz": 986.6627739691137,
"period": 1.0135175121457494,
"mean": 1.0135175121457494,
"variance": 0.0018549428524247586,
"sd": 0.0430690474984618,
"sem": 0.0019377680576875675,
"df": 493,
"critical": 1.96,
"moe": 0.0037980253930676323,
"p75": 1.0103899999999157,
"p99": 1.1888429999999062,
"p995": 1.2175170000000435,
"p999": 1.3780980000000227,
"sampleCount": 494,
"median": 1.00487499999997
}
]
}
]
},
{
"filepath": "/home/runner/work/hidash/hidash/src/findLastIndex.bench.ts",
"groups": [
{
"fullName": "src/findLastIndex.bench.ts > findLastIndex performance",
"benchmarks": [
{
"id": "-1898411277_0_0",
"name": "hidash",
"rank": 1,
"rme": 0.45183294976588584,
"samples": [],
"totalTime": 500.022504,
"min": 0.1912769999999,
"max": 0.5656979999999976,
"hz": 4737.78676169343,
"period": 0.21106901815111861,
"mean": 0.21106901815111861,
"variance": 0.0005608641677104204,
"sd": 0.023682570969183653,
"sem": 0.00048657110752759803,
"df": 2368,
"critical": 1.96,
"moe": 0.0009536793707540922,
"p75": 0.2109450000000379,
"p99": 0.28894100000002254,
"p995": 0.34821099999999205,
"p999": 0.4601499999999987,
"sampleCount": 2369,
"median": 0.20682699999997567
},
{
"id": "-1898411277_0_1",
"name": "lodash",
"rank": 2,
"rme": 0.7045371070163242,
"samples": [],
"totalTime": 500.3718289999979,
"min": 0.9226349999999002,
"max": 2.6918150000000196,
"hz": 1055.2152807147788,
"period": 0.947673918560602,
"mean": 0.947673918560602,
"variance": 0.006126992941357977,
"sd": 0.07827511061223726,
"sem": 0.0034064869437628073,
"df": 527,
"critical": 1.96,
"moe": 0.006676714409775102,
"p75": 0.9449079999999412,
"p99": 1.020377999999937,
"p995": 1.0471979999999803,
"p999": 2.6918150000000196,
"sampleCount": 528,
"median": 0.9402840000000197
}
]
}
]
},
{
"filepath": "/home/runner/work/hidash/hidash/src/groupBy.bench.ts",
"groups": [
{
"fullName": "src/groupBy.bench.ts > groupBy performance comparison",
"benchmarks": [
{
"id": "1840289664_0_0",
"name": "hidash",
"rank": 2,
"rme": 1.871603027716843,
"samples": [],
"totalTime": 500.78234100000134,
"min": 0.8368460000000368,
"max": 2.8223910000000387,
"hz": 1082.3065344470654,
"period": 0.9239526586715892,
"mean": 0.9239526586715892,
"variance": 0.04219044061607289,
"sd": 0.20540311734750497,
"sem": 0.00882281935426925,
"df": 541,
"critical": 1.96,
"moe": 0.01729272593436773,
"p75": 0.8708400000000438,
"p99": 1.8013710000000174,
"p995": 1.8083339999999453,
"p999": 2.8223910000000387,
"sampleCount": 542,
"median": 0.8536619999999857
},
{
"id": "1840289664_0_1",
"name": "lodash",
"rank": 1,
"rme": 0.9865164225376634,
"samples": [],
"totalTime": 500.61763499999586,
"min": 0.6888280000000577,
"max": 1.3897789999998622,
"hz": 1354.3270404367709,
"period": 0.7383740929203478,
"mean": 0.7383740929203478,
"variance": 0.009364381332276527,
"sd": 0.0967697335548493,
"sem": 0.0037164192277667025,
"df": 677,
"critical": 1.96,
"moe": 0.007284181686422737,
"p75": 0.7197770000000219,
"p99": 1.3335940000001756,
"p995": 1.3499050000000352,
"p999": 1.3897789999998622,
"sampleCount": 678,
"median": 0.7105145000000448
}
]
}
]
},
{
"filepath": "/home/runner/work/hidash/hidash/src/includes.bench.ts",
"groups": [
{
"fullName": "src/includes.bench.ts > includes performance",
"benchmarks": [
{
"id": "23343445_0_0",
"name": "hidash",
"rank": 1,
"rme": 0.528943521204952,
"samples": [],
"totalTime": 500.36528200000015,
"min": 24.625678000000107,
"max": 25.580674999999985,
"hz": 39.970798773364926,
"period": 25.018264100000007,
"mean": 25.018264100000007,
"variance": 0.07995110831946181,
"sd": 0.2827562701682525,
"sem": 0.06322622411605085,
"df": 19,
"critical": 2.093,
"moe": 0.13233248707489442,
"p75": 25.154468000000065,
"p99": 25.580674999999985,
"p995": 25.580674999999985,
"p999": 25.580674999999985,
"sampleCount": 20,
"median": 24.951442500000013
},
{
"id": "23343445_0_1",
"name": "lodash",
"rank": 2,
"rme": 2.5594850759623675,
"samples": [],
"totalTime": 1691.011587,
"min": 153.33451999999988,
"max": 173.41941300000008,
"hz": 5.9136200348223875,
"period": 169.10115869999998,
"mean": 169.10115869999998,
"variance": 36.611132975920576,
"sd": 6.050713427020038,
"sem": 1.913403589834632,
"df": 9,
"critical": 2.262,
"moe": 4.328118920205938,
"p75": 171.8221349999999,
"p99": 173.41941300000008,
"p995": 173.41941300000008,
"p999": 173.41941300000008,
"sampleCount": 10,
"median": 171.32899350000002
}
]
}
]
},
{
"filepath": "/home/runner/work/hidash/hidash/src/map.bench.ts",
"groups": [
{
"fullName": "src/map.bench.ts > map performance",
"benchmarks": [
{
"id": "354973082_0_0",
"name": "hidash",
"rank": 1,
"rme": 0.2446533658224135,
"samples": [],
"totalTime": 501.2794780000004,
"min": 1.5938710000000356,
"max": 1.8736239999999498,
"hz": 610.4379162316311,
"period": 1.6381682287581711,
"mean": 1.6381682287581711,
"variance": 0.001279465769246029,
"sd": 0.035769620759046765,
"sem": 0.002044813117086878,
"df": 305,
"critical": 1.96,
"moe": 0.0040078337094902805,
"p75": 1.6665770000000748,
"p99": 1.7224720000000389,
"p995": 1.7836350000000039,
"p999": 1.8736239999999498,
"sampleCount": 306,
"median": 1.6158619999999928
},
{
"id": "354973082_0_1",
"name": "lodash",
"rank": 2,
"rme": 0.2305703701645131,
"samples": [],
"totalTime": 501.33612600000095,
"min": 2.7664740000000165,
"max": 2.980213000000049,
"hz": 355.05121368412944,
"period": 2.816495089887646,
"mean": 2.816495089887646,
"variance": 0.001954037302319385,
"sd": 0.04420449414165244,
"sem": 0.0033132669155200413,
"df": 177,
"critical": 1.96,
"moe": 0.006494003154419281,
"p75": 2.847625999999991,
"p99": 2.97344099999998,
"p995": 2.980213000000049,
"p999": 2.980213000000049,
"sampleCount": 178,
"median": 2.795998999999938
}
]
}
]
},
{
"filepath": "/home/runner/work/hidash/hidash/src/mapValues.bench.ts",
"groups": [
{
"fullName": "src/mapValues.bench.ts > mapValues performance",
"benchmarks": [
{
"id": "-1099634856_0_0",
"name": "hidash",
"rank": 1,
"rme": 0.25118419814971227,
"samples": [],
"totalTime": 501.44605299999915,
"min": 1.9387159999999994,
"max": 2.1915290000000027,
"hz": 500.55234954656316,
"period": 1.997793039840634,
"mean": 1.997793039840634,
"variance": 0.001645307963262634,
"sd": 0.040562395926062284,
"sem": 0.0025602757284767645,
"df": 250,
"critical": 1.96,
"moe": 0.005018140427814458,
"p75": 2.025168000000008,
"p99": 2.1189830000000143,
"p995": 2.1582370000000424,
"p999": 2.1915290000000027,
"sampleCount": 251,
"median": 2.0052909999999997
},
{
"id": "-1099634856_0_1",
"name": "lodash",
"rank": 2,
"rme": 1.4223825803077657,
"samples": [],
"totalTime": 500.1068179999987,
"min": 2.8561809999998786,
"max": 5.209077999999977,
"hz": 331.92908799735744,
"period": 3.0126916746987873,
"mean": 3.0126916746987873,
"variance": 0.07934839924314248,
"sd": 0.28168847907421146,
"sem": 0.021863266111886655,
"df": 165,
"critical": 1.96,
"moe": 0.042852001579297846,
"p75": 2.972829999999931,
"p99": 4.216676000000007,
"p995": 5.209077999999977,
"p999": 5.209077999999977,
"sampleCount": 166,
"median": 2.9349984999998924
}
]
}
]
},
{
"filepath": "/home/runner/work/hidash/hidash/src/pickBy.bench.ts",
"groups": [
{
"fullName": "src/pickBy.bench.ts > pickBy performance",
"benchmarks": [
{
"id": "-768328280_0_0",
"name": "hidash",
"rank": 1,
"rme": 0.7177944050076794,
"samples": [],
"totalTime": 4236.168482000003,
"min": 417.1145240000001,
"max": 429.4099390000001,
"hz": 2.360623767088401,
"period": 423.6168482000003,
"mean": 423.6168482000003,
"variance": 18.070134526368744,
"sd": 4.250898084683841,
"sem": 1.344252004884826,
"df": 9,
"critical": 2.262,
"moe": 3.0406980350494766,
"p75": 428.33303500000056,
"p99": 429.4099390000001,
"p995": 429.4099390000001,
"p999": 429.4099390000001,
"sampleCount": 10,
"median": 423.21557750000056
},
{
"id": "-768328280_0_1",
"name": "lodash",
"rank": 2,
"rme": 0.7201594370566137,
"samples": [],
"totalTime": 5233.422110000001,
"min": 518.8818250000004,
"max": 531.1412070000006,
"hz": 1.9107956113251483,
"period": 523.3422110000001,
"mean": 523.3422110000001,
"variance": 27.761545558282783,
"sd": 5.268922618361631,
"sem": 1.6661796289200868,
"df": 9,
"critical": 2.262,
"moe": 3.7688983206172364,
"p75": 530.4294030000001,
"p99": 531.1412070000006,
"p995": 531.1412070000006,
"p999": 531.1412070000006,
"sampleCount": 10,
"median": 520.5435374999997
}
]
}
]
},
{
"filepath": "/home/runner/work/hidash/hidash/src/some.bench.ts",
"groups": [
{
"fullName": "src/some.bench.ts > some performance",
"benchmarks": [
{
"id": "817802700_0_0",
"name": "hidash",
"rank": 1,
"rme": 0.12752494535444214,
"samples": [],
"totalTime": 533.051068,
"min": 53.16618500000004,
"max": 53.49077199999999,
"hz": 18.759928645335723,
"period": 53.3051068,
"mean": 53.3051068,
"variance": 0.009031143159729142,
"sd": 0.09503232691947062,
"sem": 0.030051860441126003,
"df": 9,
"critical": 2.262,
"moe": 0.06797730831782701,
"p75": 53.380825999999956,
"p99": 53.49077199999999,
"p995": 53.49077199999999,
"p999": 53.49077199999999,
"sampleCount": 10,
"median": 53.28346399999998
},
{
"id": "817802700_0_1",
"name": "lodash",
"rank": 2,
"rme": 2.5725562448544688,
"samples": [],
"totalTime": 2077.462454,
"min": 187.30530599999975,
"max": 211.6841260000001,
"hz": 4.813564731697433,
"period": 207.7462454,
"mean": 207.7462454,
"variance": 55.82271091117595,
"sd": 7.471459757716423,
"sem": 2.3626830280673694,
"df": 9,
"critical": 2.262,
"moe": 5.344389009488389,
"p75": 211.11123300000008,
"p99": 211.6841260000001,
"p995": 211.6841260000001,
"p999": 211.6841260000001,
"sampleCount": 10,
"median": 210.91566250000005
}
]
}
]
},
{
"filepath": "/home/runner/work/hidash/hidash/src/sumBy.bench.ts",
"groups": [
{
"fullName": "src/sumBy.bench.ts > sumBy performance",
"benchmarks": [
{
"id": "-1788940556_0_0",
"name": "hidash",
"rank": 1,
"rme": 0.5095183509329994,
"samples": [],
"totalTime": 501.4191060000002,
"min": 6.993005999999923,
"max": 7.717581999999993,
"hz": 137.60943524956141,
"period": 7.266943565217394,
"mean": 7.266943565217394,
"variance": 0.023743856144602466,
"sd": 0.1540904154858519,
"sem": 0.0185503061206049,
"df": 68,
"critical": 1.996,
"moe": 0.03702641101672738,
"p75": 7.34959299999997,
"p99": 7.717581999999993,
"p995": 7.717581999999993,
"p999": 7.717581999999993,
"sampleCount": 69,
"median": 7.315208999999982
},
{
"id": "-1788940556_0_1",
"name": "lodash",
"rank": 2,
"rme": 0.22220076248285664,
"samples": [],
"totalTime": 507.1416499999998,
"min": 9.874618999999939,
"max": 10.3504089999999,
"hz": 100.56361965143275,
"period": 9.943953921568623,
"mean": 9.943953921568623,
"variance": 0.006169068588031511,
"sd": 0.07854341848959409,
"sem": 0.010998278464245595,
"df": 50,
"critical": 2.009,
"moe": 0.0220955414346694,
"p75": 9.949577999999974,
"p99": 10.3504089999999,
"p995": 10.3504089999999,
"p999": 10.3504089999999,
"sampleCount": 51,
"median": 9.923119000000042
}
]
}
]
},
{
"filepath": "/home/runner/work/hidash/hidash/src/uniqBy.bench.ts",
"groups": [
{
"fullName": "src/uniqBy.bench.ts > uniqBy performance",
"benchmarks": [
{
"id": "-1039251384_0_0",
"name": "hidash",
"rank": 1,
"rme": 0.22046031591081236,
"samples": [],
"totalTime": 510.44399499999986,
"min": 15.252898000000016,
"max": 15.792597,
"hz": 64.64959980575344,
"period": 15.467999848484844,
"mean": 15.467999848484844,
"variance": 0.009241021766072336,
"sd": 0.09613023336116654,
"sem": 0.016734125689986095,
"df": 32,
"critical": 2.0378,
"moe": 0.034100801331053664,
"p75": 15.515770000000089,
"p99": 15.792597,
"p995": 15.792597,
"p999": 15.792597,
"sampleCount": 33,
"median": 15.468210999999997
},
{
"id": "-1039251384_0_1",
"name": "lodash",
"rank": 2,
"rme": 0.16227330076591498,
"samples": [],
"totalTime": 503.0699830000001,
"min": 26.27932099999998,
"max": 26.70568900000012,
"hz": 37.768105118686826,
"period": 26.477367526315795,
"mean": 26.477367526315795,
"variance": 0.007945939317487556,
"sd": 0.08913999841534415,
"sem": 0.020450118153676887,
"df": 18,
"critical": 2.101,
"moe": 0.042965698240875136,
"p75": 26.495877000000064,
"p99": 26.70568900000012,
"p995": 26.70568900000012,
"p999": 26.70568900000012,
"sampleCount": 19,
"median": 26.470137000000022
}
]
}
]
}
]
}Last updated by GitHub Actions |
Contributor
|
Contributor
|
1 similar comment
Contributor
|
yujeong-jeon
force-pushed
the
feature/211_type_safety
branch
from
7dd79ec to
c5ba05a
Compare
Contributor
|
Contributor
|
마이너로 가시는게 어떠세요? 그것이 0.x 의 특권 |
Contributor
Author
|
@yceffort-naver 옷 혹시 0.x로 하면 이미 쓰시던 곳에서 터질까봐 1.0.0을 생각했는데용..! 혹시 얘도 일단 beta로 배포하여 볼까요~? |
Contributor
|
0.x는 프리 릴리즈라서 ^ 동작이 다를거라, 억지로 올리지 않으면 안터지지 않을까요? |
Contributor
Author
앗 그렇겠네요! patch는 올라가도 minor는 안올릴테니 minor로 하겠습니다~! |
yujeong-jeon
force-pushed
the
feature/211_type_safety
branch
from
c5ba05a to
74c6f00
Compare
yujeong-jeon
force-pushed
the
feature/211_type_safety
branch
from
74c6f00 to
4425908
Compare
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💥 This PR is BREKING CHANGES, BUT EXPERIMENTAL VERSION
This resolves #211
Description
This PR removes the
PropertyName (string | number | symbol)typed IterateeShorthand to simplify and improve type safety.Purpose
Changes Overview
PropertyNametyped IterateeShorthand.