Don't use inv and inv! in ring conformance tests
#2096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't expect general rings to support inv, not even for the ring's one element. These tests may be reactivated in a future version, e.g. if we add an `implements` trait.
fingolfin
added
the
release notes: not needed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2096 +/- ##
==========================================
- Coverage 88.36% 88.36% -0.01%
==========================================
Files 126 126
Lines 31627 31624 -3
==========================================
- Hits 27948 27944 -4
- Misses 3679 3680 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lgoettgens
approved these changes
May 23, 2025
That PR contains not only changes to the docu, but another actual bugfix. Maybe we should split that one off, then. |
#2077 was just updated to only the bugfix and no longer change any documentation. aka we want to merge both #2077 (in its current form) and this PR here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't expect general rings to support inv, not even for the ring's one element. These tests may be reactivated in a future version, e.g. if we add an
implementstrait.Alternative to @HechtiDerLachs's PR #2077. May fix this "properly" in PR #1957 or a follow-up, but for now this is the obvious change to make.
@HechtiDerLachs of course you might run in further issues, let me know if that's the case.