Skip to content

Don't use inv and inv! in ring conformance tests #2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

Don't use inv and inv! in ring conformance tests #2096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ext/TestExt/Rings-conformance-tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,9 +230,11 @@ function test_Ring_interface(R::AbstractAlgebra.Ring; reps = 50)
test_NCRing_interface(R; reps = reps)

@testset "Basic functionality for commutative rings only" begin
@test isone(AbstractAlgebra.inv(one(R)))
test_mutating_op_like_neg(AbstractAlgebra.inv, inv!, one(R))
test_mutating_op_like_neg(AbstractAlgebra.inv, inv!, -one(R))
# FIXME: we can't expect general rings to support inv, not even for the one
# element, so don't test this
#@test isone(AbstractAlgebra.inv(one(R)))
#test_mutating_op_like_neg(AbstractAlgebra.inv, inv!, one(R))
#test_mutating_op_like_neg(AbstractAlgebra.inv, inv!, -one(R))
for i in 1:reps
a = generate_element(R)::T
b = generate_element(R)::T
Expand Down
Loading