[19.0][MIG] delivery_gls_asm: Migration to 19.0 by RicardCForgeFlow · Pull Request #4685 · OCA/l10n-spain

RicardCForgeFlow · 2025-12-30T11:56:44Z

Se ha añadido tests. En el modo de pruebas, la cancelación de pickup devuelve el Error Desconocido -204. (Método _cancel_pickup) Esto no sé si es debido a estar en modo prueba o también ocurre en entornos de producción.

@ForgeFlow

pedrobaeza · 2025-12-30T16:20:56Z

/ocabot migration delivery_gls_asm

A revisar CI.

delivery_gls_asm/models/delivery_carrier.py

Alexgars73 · 2026-02-23T15:48:49Z

delivery_gls_asm/models/delivery_carrier.py

            # make the expedition. Try to fallback to the commercial entity one
            "destinatario_telefono": consignee.phone or consignee_entity.phone or "",
-            "destinatario_movil": consignee.mobile or consignee_entity.mobile or "",
+            "destinatario_movil": "",


Pienso que este cambio no es correcto realizando la prueba, hay veces que salta error que el móvil del destinatario es un campo obligatorio.

Vaya 😞 ! Ponemos el campo phone entonces?

En Odoo 19 han borrado el campo mobile (bastantes quejas por lo que veo):
odoo/odoo@6b820eb
odoo/odoo#189739

O usamos: https://github.com/OCA/partner-contact/tree/19.0/partner_mobile

[UPD] Update delivery_gls_asm.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-spain-12.0/l10n-spain-12.0-delivery_gls_asm Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-delivery_gls_asm/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-spain-12.0/l10n-spain-12.0-delivery_gls_asm Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-delivery_gls_asm/

Non implemented methods should raise informative exceptions if used [UPD] Update delivery_gls_asm.pot delivery_gls_asm 12.0.1.0.1 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-spain-12.0/l10n-spain-12.0-delivery_gls_asm Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-delivery_gls_asm/

delivery_gls_asm 12.0.1.0.2

The `cliente` key corresponds to the company not to the customer, wich is `nombre_dst` delivery_gls_asm 12.0.1.0.3

Alhough it will raise another exception, at least it will show the proper message and not a traceback.

Ensure that the values sent to the xml soap request are properly escaped. A partner name like "Johnson & Johnson" would fail otherwise.

[UPD] Update delivery_gls_asm.pot [UPD] README.rst

- Fix tests to declare packages explicitly - Fix wrong keyword literals on errors TT45144

New shipping times and renaming of some of them by GLS TT48760

Check the actual value that is being sent to GLS, since it doesn't make sense to error for 15 characters when the value you would send doesn't actually exceed that limit My use case is that we have some clients that deliver a whole stock.picking.batch instead of stock.picking individually, therefore the reference we use is the batch's name (overwritten through _prepare_gls_asm_shipping). This started erroring when the picking reference reached 16 characters while the batch reference is still only 10

Main github account has been renamed, the previous one now only exists as a redirect. Changing to receive notifications correctly

… code instead of phone_code

pedrobaeza

Por favor, no lo hagáis depender de partner_mobile. Eso me parece un despropósito y forzar a la gente a instalar un módulo que a lo mejor no quiere. Utilizad phone, o como mucho, si queréis detectar dinámicamente si existe el campo mobile, utilizar ése (if "mobile" in self.partner_id).

…a PickUp Service Also raise UserError if trying to send pickup with a non PickUp Service

RicardCForgeFlow · 2026-02-24T08:36:09Z

Por favor, no lo hagáis depender de partner_mobile. Eso me parece un despropósito y forzar a la gente a instalar un módulo que a lo mejor no quiere. Utilizad phone, o como mucho, si queréis detectar dinámicamente si existe el campo mobile, utilizar ése (if "mobile" in self.partner_id).

Okay! He añadido el if "mobile" in self.partner_id y quitado la dependencia de partner_mobile. Queda el codigo menos limpio, pero creo que vale la pena ganar la precisión en caso de que alguien tenga el campo mobile

Reyes4711-S73

LGTM

RicardCForgeFlow mentioned this pull request Dec 30, 2025

Migration to version 19.0 #4402

Open

34 tasks

RicardCForgeFlow marked this pull request as ready for review December 30, 2025 13:08

OCA-git-bot added this to the 19.0 milestone Dec 30, 2025

RicardCForgeFlow changed the title ~~[19.0][MIG] delivery_gls_asm~~ [19.0][MIG] delivery_gls_asm: Migration to 19.0 Dec 31, 2025

RicardCForgeFlow force-pushed the 19.0-mig-delivery_gls_asm branch 2 times, most recently from a2d86a3 to e3cc89c Compare December 31, 2025 09:08

RicardCForgeFlow marked this pull request as draft December 31, 2025 09:47

RicardCForgeFlow marked this pull request as ready for review December 31, 2025 11:30

RicardCForgeFlow marked this pull request as draft December 31, 2025 11:56

RicardCForgeFlow force-pushed the 19.0-mig-delivery_gls_asm branch 2 times, most recently from 342b823 to f6a8224 Compare January 2, 2026 11:02

RicardCForgeFlow marked this pull request as ready for review January 2, 2026 11:07

hildickethan approved these changes Jan 2, 2026

View reviewed changes

pedrobaeza reviewed Jan 7, 2026

View reviewed changes

delivery_gls_asm/models/delivery_carrier.py Show resolved Hide resolved

RicardCForgeFlow force-pushed the 19.0-mig-delivery_gls_asm branch from f6a8224 to 65b4c50 Compare January 7, 2026 09:52

RicardCForgeFlow requested a review from pedrobaeza January 21, 2026 16:50

Alexgars73 reviewed Feb 23, 2026

View reviewed changes

chienandalu and others added 12 commits February 23, 2026 18:38

[FIX] delivery_gls_asm: manifest

b3a7345

delivery_gls_asm 12.0.1.0.2

[FIX] delivery_gls_manifest: manifest destination name

6060e9c

The `cliente` key corresponds to the company not to the customer, wich is `nombre_dst` delivery_gls_asm 12.0.1.0.3

[FIX] delivery_gls_asm: Proper signature for gls_asm_rate_shipment

0b15b91

Alhough it will raise another exception, at least it will show the proper message and not a traceback.

[IMP] delivery_gls_asm: black, isort, prettier

8eb0b25

[FIX] delivery_gls_asm: escaping shipping vals for xml

e27005f

Ensure that the values sent to the xml soap request are properly escaped. A partner name like "Johnson & Johnson" would fail otherwise.

[MIG] delivery_gls_asm: Migration to 13.0

2ce838d

[UPD] Update delivery_gls_asm.pot [UPD] README.rst

Added translation using Weblate (Catalan)

84f19bb

[13.0][IMP] delivery_gls_asm: black, isort, prettier

824a7cb

[14.0][MIG] delivery_gls_asm: Migration to 14.0

34f025b

[14.0][IMP] delivery_gls_asm: Pick-up request integration

4dcfa2d

manuelregidor and others added 15 commits February 23, 2026 18:38

[FIX]delivery_gls_asm: Discontinued GetManifiesto API method

63023e7

[FIX] delivery_gls_asm: delivery_package_number compatibility

36e723e

- Fix tests to declare packages explicitly - Fix wrong keyword literals on errors TT45144

[IMP] delivery_gls_asm: Notas envío GLS

81ce149

[FIX] *: Linter fixes

9fdf217

[MIG] delivery_gls_asm: Migration to 16.0

477efd2

[IMP] delivery_gls_asm: Nuevo servicio '96 - BUSINESS PARCEL'

f0f1e44

[IMP] delivery_gls_asm: rename/add shipping times

2bedf7f

New shipping times and renaming of some of them by GLS TT48760

[IMP] delivery_gls_asm: pre-commit auto fixes

e37f4b4

[MIG] delivery_gls_asm: Migration to 17.0

2186856

[IMP] delivery_gls_asm: pre-commit auto fixes

1fca098

[MIG] delivery_gls_asm: Migration to 18.0

be034e8

[FIX] delivery_gls_asm: Update maintainers

2dfc7ff

Main github account has been renamed, the previous one now only exists as a redirect. Changing to receive notifications correctly

[IMP] delivery_gls_asm: build 'destinatario' country from ISO country…

2e09916

… code instead of phone_code

[IMP] delivery_gls_asm: pre-commit auto fixes

f0d9192

RicardCForgeFlow force-pushed the 19.0-mig-delivery_gls_asm branch from 65b4c50 to 9b1219f Compare February 23, 2026 17:39

RicardCForgeFlow marked this pull request as draft February 23, 2026 17:45

RicardCForgeFlow force-pushed the 19.0-mig-delivery_gls_asm branch 2 times, most recently from 6dcb2e5 to dbf7edd Compare February 23, 2026 17:53

pedrobaeza reviewed Feb 23, 2026

View reviewed changes

RicardCForgeFlow added 4 commits February 24, 2026 09:07

[MIG] delivery_gls_asm: Migration to 19.0

cc5298a

[IMP] delivery_gls_asm: raise UserError when validating picking with …

a01c8f5

…a PickUp Service Also raise UserError if trying to send pickup with a non PickUp Service

[IMP] delivery_gls_asm: Fix tests by forcing service to 37 [ECONOMY]

d8fba2b

[IMP] delivery_gls_asm: Improve test coverage

319cc3b

RicardCForgeFlow force-pushed the 19.0-mig-delivery_gls_asm branch from dbf7edd to 319cc3b Compare February 24, 2026 08:07

RicardCForgeFlow marked this pull request as ready for review February 24, 2026 08:12

Alexgars73 approved these changes Feb 24, 2026

View reviewed changes

OCA-git-bot added the approved label Feb 24, 2026

Reyes4711-S73 approved these changes Feb 24, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[19.0][MIG] delivery_gls_asm: Migration to 19.0#4685

[19.0][MIG] delivery_gls_asm: Migration to 19.0#4685
RicardCForgeFlow wants to merge 47 commits intoOCA:19.0from
ForgeFlow:19.0-mig-delivery_gls_asm

RicardCForgeFlow commented Dec 30, 2025 •

edited

Loading

Uh oh!

pedrobaeza commented Dec 30, 2025

Uh oh!

Uh oh!

Alexgars73 Feb 23, 2026 •

edited

Loading

Uh oh!

RicardCForgeFlow Feb 23, 2026

Uh oh!

RicardCForgeFlow Feb 23, 2026

Uh oh!

pedrobaeza left a comment

Uh oh!

RicardCForgeFlow commented Feb 24, 2026

Uh oh!

Reyes4711-S73 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

Uh oh!

Conversation

RicardCForgeFlow commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pedrobaeza commented Dec 30, 2025

Uh oh!

Uh oh!

Alexgars73 Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RicardCForgeFlow Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

RicardCForgeFlow Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

RicardCForgeFlow commented Feb 24, 2026

Uh oh!

Reyes4711-S73 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

RicardCForgeFlow commented Dec 30, 2025 •

edited

Loading

Alexgars73 Feb 23, 2026 •

edited

Loading