[16.0][IMP] stock_quantity_history_location: invisible location except from stock.quant view#423
[16.0][IMP] stock_quantity_history_location: invisible location except from stock.quant view#423AungKoKoLin1997 wants to merge 3 commits intoOCA:16.0from
Conversation
… stock.quant view
|
Hi @rolandojduartem, @luisg123v, |
yostashiro
left a comment
yostashiro
left a comment
There was a problem hiding this comment.
I think include_child_locations should be removed. See odoo/odoo#78078.
Can you please also update the README accordingly, as the usage seems outdated.
@yostashiro Done! |
AungKoKoLin1997
force-pushed
the
16.0-imp-history_location
branch
from
d839983 to
1e16800
Compare
stock_quantity_history_location/tests/test_stock_quantity_history_location.py
Outdated
Show resolved
Hide resolved
|
This PR has the |
Odoo core behavior has changed, so this module’s redundant code can be removed: - Drop the include_child_locations flag: child locations are now included by default (see odoo/odoo#78078). - Remove the company_owned context: it was removed upstream in commit odoo/odoo@6fd0575#diff-2f7d1a089caccb39f6dcaf4afe19af96ebf382886e382b22e1e956ba94a927c9.
AungKoKoLin1997
force-pushed
the
16.0-imp-history_location
branch
from
1e16800 to
3a1bd02
Compare
|
@oca/stock-logistics-reporting-maintainers |
| attrs="{'invisible': [('location_id', '=', False)]}" | ||
| name="location_id" | ||
| groups="stock.group_stock_multi_locations" | ||
| invisible="context.get('active_model') != 'stock.quant'" |
There was a problem hiding this comment.
does this work on Odoo 16.0? I think it should be attrs
There was a problem hiding this comment.
@rolandojduartem
It works on odoo 16.0. You can see how odoo standard field inventory_datetime displays in view depends on model.
https://github.com/odoo/odoo/blob/1adee2b7452c072bcce51cd75641a9e4c2b7f219/addons/stock_account/wizard/stock_quantity_history.xml#L9-L19.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
AungKoKoLin1997
force-pushed
the
16.0-imp-history_location
branch
from
3a1bd02 to
0c1063e
Compare
kanda999
left a comment
kanda999
left a comment
There was a problem hiding this comment.
Functional review: it works in prod server
github-actions
bot
removed
the
stale
6 participants
This PR makes the location field invisible when the model is not stock.quant (locations view), because the location context is not used in other models (e.g.,
stock.valuation.layer) and choosing location will not effect the functionality. So, displaying this field in the pop-up of other models (e.g., Stock Valuation Layer) may confuse users.@qrtl QT4756