Skip to content

[18.0] stock_period_evaluation#442

Open
eLBati wants to merge 6 commits intoOCA:18.0from
eLBati:stock_close_period
Open

[18.0] stock_period_evaluation#442
eLBati wants to merge 6 commits intoOCA:18.0from
eLBati:stock_close_period

Conversation

@eLBati
Copy link
Member

@eLBati eLBati commented Sep 25, 2025

No description provided.

@eLBati eLBati force-pushed the stock_close_period branch 3 times, most recently from 804b580 to 64322ab Compare September 26, 2025 10:32
@eLBati eLBati force-pushed the stock_close_period branch 3 times, most recently from b363436 to faa12a0 Compare November 7, 2025 14:43
@eLBati eLBati changed the title [18.0] stock_close_period [18.0] stock_period_evaluation Nov 7, 2025
@eLBati eLBati force-pushed the stock_close_period branch 2 times, most recently from 45838d4 to 3bea320 Compare November 7, 2025 15:00
@eLBati eLBati marked this pull request as ready for review November 7, 2025 15:02
andreampiovesana
andreampiovesana suggested changes Jan 21, 2026
View reviewed changes
Copy link

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

product selection for 18

@etobella
Copy link
Member

etobella commented Jan 30, 2026

TEsts are failing...

@sergiocorato
Copy link

sergiocorato commented Jan 31, 2026

@eLBati I've done the migration of the part of my original work useful for this PR in v. 16.0 with working tests, if you find it useful, here: https://github.com/efatto/stock-close-period/tree/16.0

@eLBati eLBati force-pushed the stock_close_period branch 3 times, most recently from 79cc8cc to 7917c63 Compare February 24, 2026 16:45
@eLBati eLBati force-pushed the stock_close_period branch from 7917c63 to ace44ce Compare February 24, 2026 16:56
@eLBati
Copy link
Member Author

eLBati commented Feb 25, 2026

TEsts are failing...

Hi @etobella , do you think failure is related to this module? I cannot even reproduce the error locally

eLBati added a commit to eLBati/l10n-italy that referenced this pull request Feb 25, 2026
@eLBati
ADD stock_period_evaluation from OCA/stock-logistics-reporting#442
632d3ed
@eLBati eLBati force-pushed the stock_close_period branch 2 times, most recently from 6ccc6f0 to 1fb056f Compare February 25, 2026 15:14
@eLBati
FIX stock_period_evaluation: remove active handling and fix tests
8bd0378 
IMP metadata and style
FIX Storable products are now type = "consu" with is_storable = True
@eLBati
Copy link
Member Author

eLBati commented Feb 25, 2026

TEsts are failing...

Hi @etobella , do you think failure is related to this module? I cannot even reproduce the error locally

nevermind, fixed tests 🍏

@eLBati eLBati force-pushed the stock_close_period branch from 1fb056f to 8bd0378 Compare February 25, 2026 15:19
andreampiovesana
andreampiovesana approved these changes Mar 5, 2026
View reviewed changes
Copy link

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MarcoCalcagni
MarcoCalcagni approved these changes Mar 11, 2026
View reviewed changes
Copy link

@MarcoCalcagni MarcoCalcagni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tests OK

Please merge

@ivs-cetmix
Copy link
Member

ivs-cetmix commented Mar 11, 2026

Hello @eLBati , thank you for your contribution! Looks good, to proceed with the merge please:

  • try to improve test coverage (if possible).
  • squash the commits, ensure that commit title and message comply with the OCA requirements.
  • add the [ADD] tag to the PR title.

@sergiocorato
Copy link

sergiocorato commented Mar 11, 2026

There was a discussion about this module, that has now a draft PR in Italian localization here: OCA/l10n-italy#5128
So the question is if this module is useful outside Italy.

@ivs-cetmix
Copy link
Member

ivs-cetmix commented Mar 11, 2026

There was a discussion about this module, that has now a draft PR in Italian localization here: OCA/l10n-italy#5128 So the question is if this module is useful outside Italy.

Good point. Franky speaking I'm not an expert on this subject, however there might be other localisations that could find this module useful. With this said I would keen to keeping it in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@MarcoCalcagni MarcoCalcagni MarcoCalcagni approved these changes

@andreampiovesana andreampiovesana andreampiovesana approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@eLBati @etobella @sergiocorato @ivs-cetmix @MarcoCalcagni @andreampiovesana @OCA-git-bot