[Server] Fix: Return full CertificateChain after Certificate Update#2861
Merged
mrsuciu merged 5 commits intoOPCFoundation:masterfrom Jan 13, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2861 +/- ##
==========================================
- Coverage 55.43% 55.40% -0.04%
==========================================
Files 352 352
Lines 67602 67615 +13
Branches 13849 13851 +2
==========================================
- Hits 37477 37462 -15
- Misses 26021 26050 +29
+ Partials 4104 4103 -1 ☔ View full report in Codecov by Sentry. |
13 tasks
mregen
reviewed
Dec 8, 2024
Libraries/Opc.Ua.Server/Configuration/ConfigurationNodeManager.cs
Outdated
Show resolved
Hide resolved
mrsuciu
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix the CertificateTypesProvider to also return the correct chain after a CertificateUpdate occured.
Types of changes
Checklist