Skip to content

[Server] Fix: Return full CertificateChain after Certificate Update#2861

Merged
mrsuciu merged 5 commits intoOPCFoundation:masterfrom
romanett:fixCertificateTypesProvider2
Jan 13, 2025
Merged

[Server] Fix: Return full CertificateChain after Certificate Update#2861
mrsuciu merged 5 commits intoOPCFoundation:masterfrom
romanett:fixCertificateTypesProvider2

Conversation

@romanett
Copy link
Contributor

Proposed changes

Fix the CertificateTypesProvider to also return the correct chain after a CertificateUpdate occured.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

@romanett romanett requested a review from mregen November 26, 2024 19:48
@codecov
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.40%. Comparing base (0777bbd) to head (49dd612).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...a.Server/Configuration/ConfigurationNodeManager.cs 77.77% 2 Missing ⚠️
Stack/Opc.Ua.Core/Stack/Server/ServerBase.cs 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2861      +/-   ##
==========================================
- Coverage   55.43%   55.40%   -0.04%     
==========================================
  Files         352      352              
  Lines       67602    67615      +13     
  Branches    13849    13851       +2     
==========================================
- Hits        37477    37462      -15     
- Misses      26021    26050      +29     
+ Partials     4104     4103       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romanett romanett requested review from mregen and mrsuciu December 17, 2024 16:05
@romanett romanett removed the request for review from mregen January 13, 2025 06:11
@mrsuciu mrsuciu merged commit 760bfd9 into OPCFoundation:master Jan 13, 2025
75 of 76 checks passed
@romanett romanett deleted the fixCertificateTypesProvider2 branch January 13, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants