Suppress expected keepalive errors during test shutdown #3458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
CI logs are cluttered with keepalive errors (
BadServerHalted,BadNoCommunication) during test teardown. These are expected when sessions close during server shutdown and create noise that obscures actual test failures.Modified
ClientFixture.Session_KeepAliveto early-return on these two status codes:Other keepalive errors (e.g.,
BadRequestInterrupted) continue to be logged. Added null-conditional operators for defensive handling.Related Issues
Issue describes CI logs being full of keepalive error messages during test shutdown.
Types of changes
Checklist
Further comments
Change is test-only and does not affect production code behavior. No additional tests needed - existing tests verify the fix works (logs are clean on shutdown).
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.