Skip to content

Suppress expected keepalive errors during test shutdown #3458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcschier merged 3 commits into from
Jan 12, 2026
+8 −1
Merged

Suppress expected keepalive errors during test shutdown #3458

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47f1e13
Initial plan
Copilot Jan 12, 2026
094e98f
Suppress BadServerHalted/BadNoCommunication keepalive errors in test …
Copilot Jan 12, 2026
4b00aea
Add null-conditional operators for safer null handling
Copilot Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Tests/Opc.Ua.Client.Tests/ClientFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,10 +515,17 @@ private void Session_KeepAlive(ISession session, KeepAliveEventArgs e)
{
if (ServiceResult.IsBad(e.Status))
{
// Ignore expected errors during test shutdown to reduce noise in CI logs
if (e.Status?.StatusCode == StatusCodes.BadServerHalted ||
e.Status?.StatusCode == StatusCodes.BadNoCommunication)
{
return;
}

m_logger.LogError(
"Session '{SessionName}' keep alive error: {StatusCode}",
session.SessionName,
e.Status.ToLongString());
e.Status?.ToLongString());
}
}
}
Expand Down
Loading