fix: replace 33 missing NLS keys causing blank wizard options#15695
Merged
wh-alice merged 4 commits intorelease/6.8from Apr 14, 2026
Merged
fix: replace 33 missing NLS keys causing blank wizard options#15695wh-alice merged 4 commits intorelease/6.8from
wh-alice merged 4 commits intorelease/6.8from
Conversation
33 NLS keys referenced in fx-core source were missing from package.nls.json, causing blank/empty labels in VS Code QuickPick menus (notably the Add Action MCP option). These core.* keys were deleted during the JSON-driven wizard migration but the old TypeScript code paths still referenced them. Fixed by: - Replacing 29 core.* key references with their template.* equivalents - Adding 4 genuinely missing keys to fx-core package.nls.json Affected files: - constants.ts: MCP and RAG option labels - CapabilityOptions.ts: CEA, Teams agent, RAG source labels - teamsProjectTypeNode.ts: RAG label/placeholder - create.ts: RAG placeholder Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Alive-Fish
approved these changes
Apr 14, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix 33 missing NLS key references that cause blank/empty labels in VS Code QuickPick menus.
Problem
After the JSON-driven wizard migration (#15560), many
core.*NLS keys were deleted fromfx-core/resource/package.nls.jsonand replaced withtemplate.*keys intemplates/src/ui/resource/package.nls.json. However, the old TypeScript code paths (used by VS platform, CLI, and Add Action flow) still reference the deletedcore.*keys, causinggetLocalizedString()to return empty strings.Most notably, the Add Action → MCP option appears as a blank clickable item because
core.createProjectQuestion.mcpForDa.labeldoesn't exist (#15629 introduced this).Fix
core.*key references with theirtemplate.*equivalentsfx-core/resource/package.nls.jsonAffected Files
constants.tsCapabilityOptions.tsteamsProjectTypeNode.tscreate.tspackage.nls.jsonVerification
bug