Remove use of embedded-usb-pd PdController trait#17
Merged
jerrysxie merged 2 commits intoOpenDevicePartnership:mainfrom Mar 28, 2025
Merged
Remove use of embedded-usb-pd PdController trait#17jerrysxie merged 2 commits intoOpenDevicePartnership:mainfrom
PdController trait#17jerrysxie merged 2 commits intoOpenDevicePartnership:mainfrom
Conversation
added 2 commits
March 27, 2025 09:56
This moves the `reset` method impl to the Tps6699x impl block See OpenDevicePartnership/embedded-services#196
RobertZ2011
approved these changes
Mar 27, 2025
jerrysxie
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See OpenDevicePartnership/embedded-services#196
Acargo update embedded-usb-pdis necessary to pick up the changes after OpenDevicePartnership/embedded-usb-pd#8 is merged.EDIT: Cargo.lock isn't checked in so this can be merged whenever, though it does depend on OpenDevicePartnership/embedded-usb-pd#8.
Closes OpenDevicePartnership/embedded-services#196