add credential type selection from workflow canvas #3929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3929 +/- ##
==========================================
+ Coverage 88.65% 88.79% +0.13%
==========================================
Files 422 422
Lines 18913 19049 +136
==========================================
+ Hits 16767 16914 +147
+ Misses 2146 2135 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
elias-ba
force-pushed
the
3906-credentials-types
branch
4 times, most recently
from
1b9868b to
423bb60
Compare
elias-ba
added a commit
that referenced
this pull request
Nov 9, 2025
- Add 4 tests for from_collab_editor flag functionality - Test that push_event is skipped when from_collab_editor is true - Test that permission checks still work with from_collab_editor - Improves coverage from ~72% to 80% for keychain component All tests verify the new conditional logic added in PR #3929 for collaborative editor integration. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
elias-ba
force-pushed
the
3906-credentials-types
branch
4 times, most recently
from
6443913 to
b3925c4
Compare
elias-ba
changed the title
elias-ba
added a commit
that referenced
this pull request
Nov 9, 2025
- Add 4 tests for from_collab_editor flag functionality - Test that push_event is skipped when from_collab_editor is true - Test that permission checks still work with from_collab_editor - Improves coverage from ~72% to 80% for keychain component All tests verify the new conditional logic added in PR #3929 for collaborative editor integration.
elias-ba
force-pushed
the
3906-credentials-types
branch
from
c83a9d2 to
2cedcca
Compare
This PR adds the ability to create credentials directly from the workflow canvas when configuring job credentials. Users can now select from OAuth, Raw JSON, and Keychain credential types through an advanced picker interface. Features: - Advanced credential type picker with OAuth, Raw, and Keychain options - Keychain credential creation and editing from collaborative editor - Back navigation between picker pages - Form validation and error handling - Integration with existing credential management system Testing: - Comprehensive integration tests for credential creation flows - Authorization tests for viewer permissions - Back navigation and form state preservation tests - Validation error handling tests
elias-ba
force-pushed
the
3906-credentials-types
branch
from
2cedcca to
475952f
Compare
elias-ba
requested review from
theroinaochieng
and removed request for
stuartc and
taylordowns2000
Resolved conflicts in: - CHANGELOG.md: Combined entries from both branches - lib/lightning_web/live/workflow_live/collaborate.ex: Merged credential type picker with webhook auth modal, updated event handler name to close_credential_modal - test/lightning_web/live/workflow_live/collaborate_test.exs: Combined credential picker tests with webhook auth modal tests
Resolved conflicts in: - CHANGELOG.md: Kept both feature entries - useWorkflow.ts: Added useWorkflowSettingsErrors hook from main
elias-ba
force-pushed
the
3906-credentials-types
branch
2 times, most recently
from
fd6623c to
1ed37e5
Compare
- Add keychain.png for keychain credential type - Add raw.png for raw JSON credential type - Update paths in credential_form_component.ex Icons are placed in /priv/static/images/ alongside other static images like user.png, google.png, etc. File names without dashes avoid gitignore patterns that exclude digested build assets.
elias-ba
force-pushed
the
3906-credentials-types
branch
from
1ed37e5 to
67dafb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to create credentials with different types directly from the workflow canvas. Users can now access an advanced credential type picker to select OAuth clients, raw JSON credentials, or keychain credentials.
Closes #3906
Closes #3947
Validation steps
📹 Quick demo video here: https://www.loom.com/share/4887974a3f4f49a988da76f52a13ce4a
Open workflow editor and click Configure Connection:
Access advanced credential type picker:
Test OAuth credential creation flow:
Test raw JSON credential creation flow:
Test keychain credential creation flow:
Additional notes for the reviewer
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Pre-submission checklist
:owner,:admin,:editor,:viewer)