Skip to content

front: rename speed limit by tag selector #14648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
clarani merged 5 commits into from
Jan 15, 2026
Merged

front: rename speed limit by tag selector #14648

clarani merged 5 commits into from
Jan 15, 2026

Conversation

@clarani
Copy link
Contributor

@clarani clarani commented Jan 7, 2026

No description provided.

@clarani clarani requested review from a team as code owners January 7, 2026 15:36
@clarani clarani requested review from eckter and elise-chin and removed request for a team January 7, 2026 15:36
@github-actions github-actions bot added area:core Work on Core Service area:front Work on Standard OSRD Interface modules area:editoast Work on Editoast Service area:ci Work on Continous Integration Pipeline Service area:integration-tests Work on Integration test, by nature related to different services area:gateway kind:api-change area:railway-manager-interface Work on Railway Manager Interface service labels Jan 7, 2026
@clarani clarani marked this pull request as draft January 7, 2026 15:36
@clarani clarani moved this to Awaiting merge in Board PI 18 Jan 7, 2026
@clarani clarani self-assigned this Jan 7, 2026
@clarani clarani force-pushed the cni/8340-refacto-use-speed-limit-tags branch from afd0676 to 462ab79 Compare January 7, 2026 16:28
@Khoyo Khoyo removed request for a team, eckter and elise-chin January 7, 2026 16:32
@github-actions github-actions bot removed area:core Work on Core Service area:editoast Work on Editoast Service area:ci Work on Continous Integration Pipeline Service area:integration-tests Work on Integration test, by nature related to different services area:gateway kind:api-change area:railway-manager-interface Work on Railway Manager Interface service labels Jan 13, 2026
@clarani clarani force-pushed the cni/rename-speedLimitByTagSelector branch from fd76adf to db32b23 Compare January 13, 2026 10:36
@clarani clarani marked this pull request as ready for review January 13, 2026 10:55
@clarani clarani enabled auto-merge January 13, 2026 15:00
SarahBellaha
SarahBellaha reviewed Jan 14, 2026
View reviewed changes
@clarani clarani requested a review from SarahBellaha January 15, 2026 09:40
@clarani clarani force-pushed the cni/rename-speedLimitByTagSelector branch from e90fae3 to d249563 Compare January 15, 2026 09:44
SarahBellaha
SarahBellaha approved these changes Jan 15, 2026
View reviewed changes
Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll let you rename the SpeedLimitTagSelector prop called in StdcmConsist.tsx and that's it ^^

@clarani clarani requested a review from SarahBellaha January 15, 2026 14:36
SarahBellaha
SarahBellaha approved these changes Jan 15, 2026
View reviewed changes
Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Math-R
Math-R approved these changes Jan 15, 2026
View reviewed changes
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@clarani clarani added this pull request to the merge queue Jan 15, 2026
Merged via the queue into dev with commit 815aeec Jan 15, 2026
29 checks passed
@clarani clarani deleted the cni/rename-speedLimitByTagSelector branch January 15, 2026 16:09
@github-project-automation github-project-automation bot moved this from Awaiting merge to Awaiting Validation in Board PI 18 Jan 15, 2026
@louisgreiner louisgreiner moved this from Awaiting Validation to Done in Board PI 18 Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Math-R Math-R Math-R approved these changes

@SarahBellaha SarahBellaha SarahBellaha approved these changes

Assignees

@clarani clarani

Labels

area:front Work on Standard OSRD Interface modules

Projects

Board PI 18
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@clarani @Math-R @SarahBellaha