front: rename speed limit by tag selector

front/src/applications/editor/tools/rangeEdition/speedSection/SpeedSectionEditionLeftPanel.tsx

@@ -25,7 +25,7 @@ import type { ExtendedEditorContextType, PartialOrReducer } from 'applications/e
 import { osrdEditoastApi } from 'common/api/osrdEditoastApi';
 import CheckboxRadioSNCF from 'common/BootstrapSNCF/CheckboxRadioSNCF';
 import { useInfraID } from 'common/osrdContext';
-import useSpeedLimitTags from 'common/SpeedLimitByTagSelector/useSpeedLimitTags';
+import useSpeedLimitTags from 'common/SpeedLimitTagSelector/useSpeedLimitTags';
 import { isEmptyArray, toggleElement } from 'utils/array';
 
 import SwitchList from './SwitchList';

front/src/applications/operationalStudies/views/Scenario/components/ManageTimetableItem/Itinerary/ItineraryModalFormHeader.tsx

@@ -12,7 +12,7 @@ import type {
   TrainCategory,
 } from 'common/api/osrdEditoastApi';
 import { useOsrdConfActions } from 'common/osrdContext';
-import useSpeedLimitTags from 'common/SpeedLimitByTagSelector/useSpeedLimitTags';
+import useSpeedLimitTags from 'common/SpeedLimitTagSelector/useSpeedLimitTags';
 import useStoreDataForRollingStockSelector from 'modules/rollingStock/components/RollingStockSelector/useStoreDataForRollingStockSelector';
 import isMainCategory from 'modules/rollingStock/helpers/category';
 import useCategoryOptions from 'modules/rollingStock/hooks/useCategoryOptions';

front/src/applications/operationalStudies/views/Scenario/components/ManageTimetableItem/ManageTimetableItem.tsx

@@ -12,7 +12,7 @@ import simulationSettings from 'assets/pictures/components/simulationSettings.sv
 import rollingStockPic from 'assets/pictures/components/train.svg';
 import { type Comfort } from 'common/api/osrdEditoastApi';
 import { useOsrdConfActions } from 'common/osrdContext';
-import useSpeedLimitTags from 'common/SpeedLimitByTagSelector/useSpeedLimitTags';
+import useSpeedLimitTags from 'common/SpeedLimitTagSelector/useSpeedLimitTags';
 import { useSubCategoryContext } from 'common/SubCategoryContext';
 import Tabs from 'common/Tabs';
 import IncompatibleConstraints from 'modules/pathfinding/components/IncompatibleConstraints';
@@ -62,7 +62,7 @@ const ManageTimetableItem = () => {
   const origin = useSelector(getOrigin);
   const destination = useSelector(getDestination);
   const pathSteps = useSelector(getPathSteps);
-  const speedLimitByTag = useSelector(getOperationalStudiesSpeedLimitByTag);
+  const selectedSpeedLimitTag = useSelector(getOperationalStudiesSpeedLimitByTag);
   const rollingStockId = useSelector(getOperationalStudiesRollingStockID);
   const currentCategory = useSelector(getCategory);
 
@@ -214,9 +214,9 @@ const ManageTimetableItem = () => {
     content: (
       <div>
         <SimulationSettings
-          selectedSpeedLimitByTag={speedLimitByTag}
+          selectedSpeedLimitTag={selectedSpeedLimitTag}
           speedLimitTags={speedLimitTags}
-          dispatchUpdateSpeedLimitByTag={onSelectSpeedLimitTag}
+          updateSpeedLimitTag={onSelectSpeedLimitTag}
           constraintDistribution={constraintDistribution}
         />
         {rollingStock && isElectric(rollingStock.effort_curves.modes) && pathProperties && (

front/src/applications/operationalStudies/views/Scenario/components/ManageTimetableItem/SimulationSettings.tsx

@@ -1,20 +1,20 @@
 import type { Distribution } from 'common/api/osrdEditoastApi';
-import SpeedLimitByTagSelector from 'common/SpeedLimitByTagSelector';
+import SpeedLimitTagSelector from 'common/SpeedLimitTagSelector';
 
 import ConstraintDistributionSwitch from './ConstraintDistributionSwitch';
 import ElectricalProfiles from './ElectricalProfiles';
 
 type Props = {
-  selectedSpeedLimitByTag?: string;
+  selectedSpeedLimitTag?: string;
   speedLimitTags: string[];
-  dispatchUpdateSpeedLimitByTag: (newTag: string | null) => void;
+  updateSpeedLimitTag: (newTag: string | null) => void;
   constraintDistribution: Distribution;
 };
 
 const SimulationSettings = ({
-  selectedSpeedLimitByTag: speedLimitByTag,
+  selectedSpeedLimitTag,
   speedLimitTags,
-  dispatchUpdateSpeedLimitByTag,
+  updateSpeedLimitTag,
   constraintDistribution,
 }: Props) => (
   <div className="simulation-settings">
@@ -23,10 +23,10 @@ const SimulationSettings = ({
       <ConstraintDistributionSwitch constraintDistribution={constraintDistribution} />
     </div>
     <div className="second-row">
-      <SpeedLimitByTagSelector
-        selectedSpeedLimitByTag={speedLimitByTag}
+      <SpeedLimitTagSelector
+        selectedSpeedLimitTag={selectedSpeedLimitTag}
         speedLimitTags={speedLimitTags}
-        dispatchUpdateSpeedLimitByTag={dispatchUpdateSpeedLimitByTag}
+        updateSpeedLimitTag={updateSpeedLimitTag}
         showPlaceHolder
       />
     </div>

front/src/applications/stdcm/components/StdcmForm/StdcmConsist.tsx

@@ -21,7 +21,7 @@ import type {
   LoadingGaugeType,
 } from 'common/api/osrdEditoastApi';
 import { useOsrdConfActions } from 'common/osrdContext';
-import SpeedLimitByTagSelector from 'common/SpeedLimitByTagSelector';
+import SpeedLimitTagSelector from 'common/SpeedLimitTagSelector';
 import RollingStock2Img from 'modules/rollingStock/components/RollingStock2Img';
 import { useStoreDataForRollingStockSelector } from 'modules/rollingStock/components/RollingStockSelector/useStoreDataForRollingStockSelector';
 import useFilterRollingStock from 'modules/rollingStock/hooks/useFilterRollingStock';
@@ -83,11 +83,11 @@ const StdcmConsist = ({
 }: StdcmConsistProps) => {
   const { t } = useTranslation('stdcm');
 
-  const speedLimitByTag = useSelector(getStdcmSpeedLimitByTag);
+  const selectedSpeedLimitTag = useSelector(getStdcmSpeedLimitByTag);
   const speedLimitsByTag = useSelector(getStdcmSpeedLimitsByTag);
   const speedLimitTags = useMemo(
     () => removeDuplicates(Object.keys(speedLimitsByTag)).sort(),
-    [speedLimitByTag]
+    [speedLimitsByTag]
   );
   const trackSectionIdsByLoadingGauge = useSelector(getTrackSectionIdsByLoadingGauge);
   const loadingGauges = trackSectionIdsByLoadingGauge
@@ -160,7 +160,7 @@ const StdcmConsist = ({
   );
 
   const handleRollingStockSelect = (option?: LightRollingStockWithLiveries) => {
-    prefillConsist(option, towedRollingStock, speedLimitByTag);
+    prefillConsist(option, towedRollingStock, selectedSpeedLimitTag);
     dispatch(updateRollingStockID(option?.id));
     setStatusMessagesVisible({
       mass: true,
@@ -169,7 +169,7 @@ const StdcmConsist = ({
     });
   };
 
-  const onSpeedLimitByTagChange = (newTag: string | null) => {
+  const onSpeedLimitTagChange = (newTag: string | null) => {
     dispatch(
       updateMaxSpeed(
         calculateConsistMaxSpeed(
@@ -277,7 +277,7 @@ const StdcmConsist = ({
           value={towedRollingStock}
           getSuggestionLabel={(suggestion: TowedRollingStock) => suggestion.name}
           onSelectSuggestion={(towed) => {
-            prefillConsist(rollingStock, towed, speedLimitByTag);
+            prefillConsist(rollingStock, towed, selectedSpeedLimitTag);
             dispatch(updateTowedRollingStockID(towed?.id));
           }}
           {...towedRollingStockComboBoxDefaultProps}
@@ -342,11 +342,11 @@ const StdcmConsist = ({
         />
       </div>
       <div className="stdcm-consist__properties">
-        <SpeedLimitByTagSelector
+        <SpeedLimitTagSelector
           disabled={disabled}
-          selectedSpeedLimitByTag={speedLimitByTag}
+          selectedSpeedLimitTag={selectedSpeedLimitTag}
           speedLimitTags={speedLimitTags}
-          dispatchUpdateSpeedLimitByTag={onSpeedLimitByTagChange}
+          updateSpeedLimitTag={onSpeedLimitTagChange}
           showPlaceHolder={isDebugMode}
           narrow
         />

front/src/common/Map/components/LayersModal.tsx

@@ -18,7 +18,7 @@ import SwitchSNCF from 'common/BootstrapSNCF/SwitchSNCF/SwitchSNCF';
 import MapSettingsBackgroundSwitches from 'common/Map/Settings/MapSettingsBackgroundSwitches';
 import { Icon2SVG } from 'common/Map/Settings/MapSettingsLayers';
 import MapSettingsMapStyle from 'common/Map/Settings/MapSettingsMapStyle';
-import useSpeedLimitTags from 'common/SpeedLimitByTagSelector/useSpeedLimitTags';
+import useSpeedLimitTags from 'common/SpeedLimitTagSelector/useSpeedLimitTags';
 import type { LayersSettings } from 'reducers/commonMap/types';
 
 import { useMapContext } from '../useMapContext';

front/src/common/SpeedLimitByTagSelector/SpeedLimitByTagSelector.tsx → front/src/common/SpeedLimitTagSelector/SpeedLimitTagSelector.tsx

@@ -1,41 +1,33 @@
-import { useMemo } from 'react';
-
 import { Select } from '@osrd-project/ui-core';
 import cx from 'classnames';
-import { isEmpty } from 'lodash';
 import { useTranslation } from 'react-i18next';
 
 import { createStandardSelectOptions } from 'utils/uiCoreHelpers';
 
-type SpeedLimitByTagSelectorProps = {
+type SpeedLimitTagSelectorProps = {
   condensed?: boolean;
   disabled?: boolean;
-  selectedSpeedLimitByTag?: string;
+  selectedSpeedLimitTag?: string;
   speedLimitTags: string[];
-  dispatchUpdateSpeedLimitByTag: (newTag: string | null) => void;
+  updateSpeedLimitTag: (newTag: string | null) => void;
   className?: string;
   showPlaceHolder?: boolean;
   narrow?: boolean;
 };
 
-export default function SpeedLimitByTagSelector({
+const SpeedLimitTagSelector = ({
   condensed = false,
   disabled = false,
-  selectedSpeedLimitByTag: speedLimitByTag,
+  selectedSpeedLimitTag: speedLimitTag,
   speedLimitTags,
-  dispatchUpdateSpeedLimitByTag,
+  updateSpeedLimitTag,
   className = '',
   showPlaceHolder = false,
   narrow = false,
-}: SpeedLimitByTagSelectorProps) {
+}: SpeedLimitTagSelectorProps) => {
   const { t } = useTranslation('operational-studies', { keyPrefix: 'manageTimetableItem' });
 
-  const speedLimitsTagsList = useMemo(
-    () => (!isEmpty(speedLimitTags) ? speedLimitTags : []),
-    [speedLimitTags]
-  );
-
-  if (!speedLimitsTagsList.length) return null;
+  if (!speedLimitTags.length) return null;
   return (
     <div className="osrd-config-item">
       <div
@@ -49,21 +41,23 @@ export default function SpeedLimitByTagSelector({
         <Select
           disabled={disabled}
           id="speed-limit-by-tag-selector"
-          value={speedLimitByTag || ''}
+          value={speedLimitTag || ''}
           label={t('speedLimitByTagAbbrev')}
           // The placeHolder is only displayed in operationalStudies and in debug mode in stdcm
           placeholder={showPlaceHolder ? t('noSpeedLimitByTag') : undefined}
           onChange={(e) => {
             if (e) {
-              dispatchUpdateSpeedLimitByTag(e);
+              updateSpeedLimitTag(e);
             } else {
-              dispatchUpdateSpeedLimitByTag(null);
+              updateSpeedLimitTag(null);
             }
           }}
-          {...createStandardSelectOptions(speedLimitsTagsList)}
+          {...createStandardSelectOptions(speedLimitTags)}
           narrow={narrow}
         />
       </div>
     </div>
   );
-}
+};
+
+export default SpeedLimitTagSelector;

front/src/common/SpeedLimitTagSelector/index.ts

@@ -0,0 +1,3 @@
+import SpeedLimitTagSelector from './SpeedLimitTagSelector';
+
+export default SpeedLimitTagSelector;

front/src/common/common.scss

@@ -16,4 +16,4 @@
 @use './Loaders/Loader.scss';
 @use './Map/MapKey.scss';
 @use './Notifications/Notifications.scss';
-@use './SpeedLimitByTagSelector/SpeedLimitByTagSelector.scss';
+@use './SpeedLimitTagSelector/SpeedLimitTagSelector.scss';