[API compatibility] support windows api #76237

zty-king · 2025-11-05T09:48:55Z

PR Category

User Experience

PR Types

Others

Description

当前调用这几个窗口函数时，使用的是paddle.audio.functional.get_window；为了和pytorch完全对齐，即使用torch.xxx_window调用，需要在外层封装一层。
经查证一共pytorch共包含以下5个window函数：bartlett_window, blackman_window, hamming_window, hann_window, kaiser_window。均在get_window中实现，直接封装即可
-以下是window函数与参数暴露情况的对应关系，同时加入了get_window进行对比：

paddle-bot · 2025-11-05T09:49:01Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zty-king · 2025-11-06T17:18:08Z

./re-run all-failed

… align_window_func_with_torch

codecov-commenter · 2025-11-07T09:55:07Z

Codecov Report

❌ Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@581ee0a). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
python/paddle/audio/functional/window.py	89.74%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             develop   #76237   +/-   ##
==========================================
  Coverage           ?   90.00%           
==========================================
  Files              ?        2           
  Lines              ?       40           
  Branches           ?        0           
==========================================
  Hits               ?       36           
  Misses             ?        4           
  Partials           ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

zty-king · 2025-11-08T04:42:21Z

/re-run all-failed

zty-king · 2025-11-13T03:57:46Z

/re-run all-failed

zty-king · 2025-11-13T04:07:24Z

中文文档Pr链接：PaddlePaddle/docs#7631

zty-king · 2025-11-13T08:20:37Z

/re-run all-failed

… align_window_func_with_torch

zhwesky2010

竞品支持的参数，除了layout、memory_format，其他都需要支持。

zhwesky2010 · 2025-11-17T08:15:10Z

python/paddle/audio/functional/window.py

+        warnings.warn("layout only supports 'strided' in Paddle; ignored")
+
+    # device: accept PlaceLike strings like 'cpu', 'gpu:0', 'cuda:0'
+    if device is not None:


这个你可以直接调 _get_paddle_place

参考下paddle.full、random是如何处理这几个参数的，可以复制过来

zty-king · 2025-11-17T08:17:36Z

已经都支持了，您看一下

@@ -445,3 +446,266 @@ def get_window(

params = (win_length, *args) kwargs = {'sym': sym} return winfunc(*params, dtype=dtype, **kwargs) + + +def _apply_window_postprocess( + w: Tensor, + *, + layout: str | None = None, + device: str | None = None, + pin_memory: None | bool, + requires_grad: None | bool, +) -> Tensor: + if layout is not None: + warnings.warn("layout only supports 'strided' in Paddle; ignored") + + # device: accept PlaceLike strings like 'cpu', 'gpu:0', 'cuda:0' + if device is not None: 这个你可以直接调 _get_paddle_place 参考下paddle.full、random是如何处理这几个参数的，可以复制过来 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>

zhwesky2010 · 2025-11-17T08:18:03Z

test/legacy_test/test_window.py

@@ -0,0 +1,179 @@
+# Copyright (c) 2025 PaddlePaddle Authors. All Rights Reserved.


这个命名改一下：test_window.py

zhwesky2010 · 2025-11-18T03:58:40Z

@zty-king 没看到提交呢，没有git push吗

… align_window_func_with_torch

zty-king · 2025-11-18T05:25:13Z

@zty-king 没看到提交呢，没有git push吗

昨天有点别的工作处理，已经修改，您看一下

zhwesky2010 · 2025-11-18T07:56:28Z

test/legacy_test/CMakeLists.txt

 set_tests_properties(test_legacy_loss_args PROPERTIES TIMEOUT 10)
 set_tests_properties(test_activation_nn_grad PROPERTIES TIMEOUT 250)
 set_tests_properties(test_empty_op PROPERTIES TIMEOUT 120)
+set_tests_properties(test_window PROPERTIES TIMEOUT 10)


这个地方能不要改不，会触发需要额外的approve

好的，已经去掉了

zhwesky2010 · 2025-11-18T08:01:02Z

python/paddle/audio/functional/window.py

+        warnings.warn("layout only supports 'strided' in Paddle; ignored")
+
+    if in_dynamic_or_pir_mode():
+        device = (


你这后面没有对device做处理呢，paddle.full的kernel可以直接传递一个device，而这个并没有处理device。

抱歉漏掉了，已更正

zty-king · 2025-11-19T02:31:59Z

/re-run all-failed

zhwesky2010 · 2025-11-19T14:29:59Z

python/paddle/audio/functional/window.py

+                raise RuntimeError(
+                    f"Pinning memory is not supported for {device}"
+                )
+    w = paddle.to_tensor(w, place=device)


用Tensor.to是不是好点？

zhwesky2010 · 2025-11-19T14:30:31Z

python/paddle/audio/functional/window.py

+                )
+    w = paddle.to_tensor(w, place=device)
+    if pin_memory and paddle.in_dynamic_mode():
+        w = w.pin_memory()


这里还需要吗，上面已经设置了pinnedplace

我看full这里写了，不知道是不是有什么特殊兜底处理，就一起带过来了

zhwesky2010 · 2025-11-19T14:41:39Z

@unittest.skipIf. 是否是必要的，触发了CI拦截

zty-king · 2025-11-19T14:44:12Z

@unittest.skipIf. 是否是必要的，触发了CI拦截

这个确实需要，因为在纯CPU环境下，那个包含device为gpu的测试会报错，所以需要在纯CPU环境下需要跳过这条测试

zhwesky2010 · 2025-11-19T14:56:40Z

test/legacy_test/test_window.py

+
+    @unittest.skipUnless(_has_cuda(), "GPU not available")
+    def test_hamming_device_gpu_pin_memory(self):
+        if paddle.is_compiled_with_cuda():


这里不是有判断吗，为什么单测还会报错。这个case改下吧。不支持的不用加。尽量不要skipif

好的，之前好像是在哪被CI拦截了，我再尝试一下

zty-king · 2025-11-20T04:39:38Z

/re-run all-failed

zty-king · 2025-11-20T06:49:26Z

/re-run all-failed

zhwesky2010

LGTM

zhwesky2010 · 2025-11-26T07:31:08Z

@zty-king 这个返回结果与torch不一致，无法通过PaConvert的测试：

FAILED tests/test_blackman_window.py::test_case_1 - AssertionError: API (torch.blackman_window): dtype mismatch, torch dtype is float32, paddle dtype is float64
FAILED tests/test_blackman_window.py::test_case_3 - AssertionError: API (torch.blackman_window): dtype mismatch, torch dtype is float32, paddle dtype is float64
FAILED tests/test_blackman_window.py::test_case_4 - AssertionError: API (torch.blackman_window): dtype mismatch, torch dtype is float32, paddle dtype is float64
FAILED tests/test_blackman_window.py::test_case_5 - AssertionError: API (torch.blackman_window): dtype mismatch, torch dtype is float32, paddle dtype is float64

zty-king · 2025-11-26T07:47:59Z

@zty-king 这个返回结果与torch不一致，无法通过PaConvert的测试：

FAILED tests/test_blackman_window.py::test_case_1 - AssertionError: API (torch.blackman_window): dtype mismatch, torch dtype is float32, paddle dtype is float64
FAILED tests/test_blackman_window.py::test_case_3 - AssertionError: API (torch.blackman_window): dtype mismatch, torch dtype is float32, paddle dtype is float64
FAILED tests/test_blackman_window.py::test_case_4 - AssertionError: API (torch.blackman_window): dtype mismatch, torch dtype is float32, paddle dtype is float64
FAILED tests/test_blackman_window.py::test_case_5 - AssertionError: API (torch.blackman_window): dtype mismatch, torch dtype is float32, paddle dtype is float64

Done.
#76623

align_window_func_with_torch

ea05b6a

paddle-bot bot added the contributor External developers label Nov 5, 2025

zty-king added 2 commits November 6, 2025 15:55

combine develop

5cc6154

adapt the parameters

755f1d2

zty-king added 2 commits November 7, 2025 03:05

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

d109814

… align_window_func_with_torch

add test

747eba5

fix the cpu_only_paddle

86055ae

add comment

a7457d0

zty-king changed the title ~~align_window_func_with_torch~~ [API Compatibility] align_window_func_with_torch Nov 13, 2025

zty-king changed the title ~~[API Compatibility] align_window_func_with_torch~~ align_window_func_with_torch Nov 13, 2025

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

69a28f7

… align_window_func_with_torch

zhwesky2010 changed the title ~~align_window_func_with_torch~~ [API compatibility] support windows api Nov 17, 2025

zhwesky2010 added the API Compatibility label Nov 17, 2025

zhwesky2010 reviewed Nov 17, 2025

View reviewed changes

zty-king added 2 commits November 18, 2025 05:21

fix the operate logic

abc1991

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

032d325

… align_window_func_with_torch

zhwesky2010 reviewed Nov 18, 2025

View reviewed changes

add device process

62f3c7d

zhwesky2010 reviewed Nov 19, 2025

View reviewed changes

zhwesky2010 previously approved these changes Nov 19, 2025

View reviewed changes

zhwesky2010 reviewed Nov 19, 2025

View reviewed changes

optimize code

6da8c0c

zty-king dismissed zhwesky2010’s stale review via 6da8c0c November 19, 2025 15:04

zhwesky2010 approved these changes Nov 20, 2025

View reviewed changes

zhwesky2010 merged commit 311b737 into PaddlePaddle:develop Nov 20, 2025
160 of 170 checks passed

zty-king deleted the align_window_func_with_torch branch November 23, 2025 13:58

		@@ -0,0 +1,179 @@
		# Copyright (c) 2025 PaddlePaddle Authors. All Rights Reserved.

[API compatibility] support windows api #76237

[API compatibility] support windows api #76237

Conversation

zty-king commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Category

PR Types

Description

Uh oh!

paddle-bot bot commented Nov 5, 2025

Uh oh!

zty-king commented Nov 6, 2025

Uh oh!

codecov-commenter commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zty-king commented Nov 8, 2025

Uh oh!

zty-king commented Nov 13, 2025

Uh oh!

zty-king commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zty-king commented Nov 13, 2025

Uh oh!

zhwesky2010 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zty-king commented Nov 17, 2025 via email

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhwesky2010 commented Nov 18, 2025

Uh oh!

zty-king commented Nov 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zty-king commented Nov 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhwesky2010 commented Nov 19, 2025

Uh oh!

zty-king commented Nov 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zty-king commented Nov 20, 2025

Uh oh!

zty-king commented Nov 20, 2025

Uh oh!

zhwesky2010 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zhwesky2010 commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zty-king commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

zty-king commented Nov 5, 2025 •

edited

Loading

codecov-commenter commented Nov 7, 2025 •

edited

Loading

zty-king commented Nov 13, 2025 •

edited

Loading

zhwesky2010 commented Nov 26, 2025 •

edited

Loading

zty-king commented Nov 26, 2025 •

edited

Loading