Skip to content

Conversation

@jwklong
Copy link
Member

@jwklong jwklong commented Oct 28, 2025

ok sooo i noticed a thing where if it fails to generate a stack it attempts to generate a input
so i've switched it around so it will try to generate input first, and if it fails it will generate stack
why did i do this? ummm so dual block actually shows a bubble
also this does clear a todo to move a piece of code to the generate function
test somewhen

@jwklong
Copy link
Member Author

jwklong commented Oct 28, 2025

can confirm that it works and that other blocks are unaffected
image
now i need to get rid of all the bad input warns

@jwklong
Copy link
Member Author

jwklong commented Oct 28, 2025

ok i just removed the warns cause it throws errors anyway so whats really the point
anddd ive done more testing and im pretty sure this is all stable so
im gonna just mark this as non-draft now and wait for someone to review (probably sharkpool)

@jwklong jwklong marked this pull request as ready for review October 28, 2025 17:21
@SharkPool-SP
Copy link

This seems unsafe

@jwklong
Copy link
Member Author

jwklong commented Oct 28, 2025

how

@jwklong
Copy link
Member Author

jwklong commented Oct 28, 2025

gng it throws errors anyway how does it provide extra debugging info

@SharkPool-SP
Copy link

gng it throws errors anyway how does it provide extra debugging info

Errors doesn't include the block info.

@jwklong
Copy link
Member Author

jwklong commented Oct 28, 2025

image then you can view the scope tag when it breakpoints and see the block var

@SharkPool-SP
Copy link

image

then you can view the scope tag when it breakpoints and see the block var

No that's stupid

@jwklong
Copy link
Member Author

jwklong commented Oct 28, 2025

how

@SharkPool-SP
Copy link

Additionally this makes compiling a bit slower.

There's a better way to do this if you're trying to make the dual block work

@jwklong
Copy link
Member Author

jwklong commented Oct 28, 2025

how is it slower???? it did the exact same before but instead of doing reporter first it did stack first

@SharkPool-SP
Copy link

Compiled scripts are made of stacks not reporters

You're making it preferable reporters first, which makes compilation slightly slower

@SharkPool-SP
Copy link

But again, there's a better way to do this

@jwklong
Copy link
Member Author

jwklong commented Oct 28, 2025

its basically the same, plus it only applies when the thing is actually clicked so for actually running projects theres no difference

@SharkPool-SP
Copy link

Okay fine, but still, put the logs back.

@jwklong
Copy link
Member Author

jwklong commented Oct 28, 2025

k fine but it'll be debug mode only

@SharkPool-SP
Copy link

k fine but it'll be debug mode only

Okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants