Skip to content

generate input first #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

generate input first #165

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d9248dc
generate input first
jwklong Oct 28, 2025
95e1eff
fix
jwklong Oct 28, 2025
5a71f7e
remove unnecessary warns when it already throws errors
jwklong Oct 28, 2025
a63c907
add silly warns
jwklong Oct 28, 2025
8dbb808
cleanup
jwklong Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 19 additions & 21 deletions src/compiler/irgen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1016,7 +1016,7 @@ class ScriptTreeGenerator {
};
}

log.warn(`IR: Unknown input: ${block.opcode}`, block);
if (this.debug) log.warn(`IR: Unknown input: ${block.opcode}`, block);
throw new Error(`IR: Unknown input: ${block.opcode}`);
}
}
Expand Down Expand Up @@ -2063,21 +2063,7 @@ class ScriptTreeGenerator {
}
}

// When this thread was triggered by a stack click, attempt to compile as an input.
// TODO: perhaps this should be moved to generate()?
if (this.thread.stackClick) {
try {
const inputNode = this.descendInput(block);
return {
kind: 'visualReport',
input: inputNode
};
} catch (e) {
// Ignore
}
}

log.warn(`IR: Unknown stacked block: ${block.opcode}`, block);
if (this.debug) log.warn(`IR: Unknown stacked block: ${block.opcode}`, block);
throw new Error(`IR: Unknown stacked block: ${block.opcode}`);
}
}
Expand Down Expand Up @@ -2373,23 +2359,35 @@ class ScriptTreeGenerator {
// We do need to evaluate empty hats
const hatInfo = this.runtime._hats[topBlock.opcode];
const isHat = !!hatInfo;
const isProcHat = topBlock.opcode === 'procedures_definition' || topBlock.opcode === 'procedures_definition_return';
if (isHat) {
this.script.stack = this.walkHat(topBlock);
} else {
// We don't evaluate the procedures_definition top block as it never does anything
// We also don't want it to be treated like a hat block
let entryBlock;
if (
topBlock.opcode === 'procedures_definition'
|| topBlock.opcode === 'procedures_definition_return'
) {
if (isProcHat) {
entryBlock = topBlock.next;
} else {
entryBlock = topBlockId;
}

if (entryBlock) {
this.script.stack = this.walkStack(entryBlock);
const entryBlockObj = this.getBlockById(entryBlock);

// When this thread was triggered by a stack click, attempt to compile as an input.
if (this.thread.stackClick && !isProcHat && !entryBlockObj.next) {
try {
const inputNode = this.descendInput(entryBlockObj);
this.script.stack = [{
kind: 'visualReport',
input: inputNode
}];
} catch (e) {
// Ignore
}
}
this.script.stack ??= this.walkStack(entryBlock);
}
}

Expand Down