Make LoaderMap a singleton instance#37
Open
rictic wants to merge 1 commit into
Open
Conversation
This lets closure compiler understand it much better, allowing us to turn on --collapse_properties, which greatly reduces binary size
Contributor
Author
|
All internal tests pass. |
Contributor
|
Let's wait for the final 3.0 releases before merging this, just to avoid unnecessary churn. cc @bicknellr |
Contributor
Author
|
Any reason for that? We've been merging other no-op internal changes |
Contributor
|
Wouldn't you want to get this in before the next release so that it's available in all the upcoming tests with that release? |
Contributor
|
Please don't merge this until the final release. |
bicknellr
changed the base branch from
__auto_generated_3.0_preview
to
master
September 14, 2018 22:45
e111077
approved these changes
Sep 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets closure compiler understand it much better, allowing us to turn on --collapse_properties, which greatly reduces binary size