Skip to content

Make LoaderMap a singleton instance #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rictic wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make LoaderMap a singleton instance #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions iron-jsonp-library.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,17 +106,17 @@ export const IronJsonpLibraryBehavior = {
}
};

/**
* LoaderMap keeps track of all Loaders
*/
var LoaderMap = {
apiMap: {}, // { hash -> Loader }
class LoaderMapClass {
constructor() {
this.apiMap = {}; // { hash -> Loader }
}

/**
* @param {string} url .
* @param {Function} notifyCallback loaded callback fn(result)
* @param {string} jsonpCallbackName name of jsonpcallback. If API does not provide it, leave empty. Optional.
*/
require: function(url, notifyCallback, jsonpCallbackName) {
require(url, notifyCallback, jsonpCallbackName) {
// make hashable string form url
var name = this.nameFromUrl(url);

Expand All @@ -126,12 +126,21 @@ var LoaderMap = {

// ask for notification
this.apiMap[name].requestNotify(notifyCallback);
},
}

nameFromUrl: function(url) {
/**
* @param {string} url
* @return {string}
*/
nameFromUrl(url) {
return url.replace(/[\:\/\%\?\&\.\=\-\,]/g, '_') + '_api';
}
};
}

/**
* LoaderMap keeps track of all Loaders
*/
var LoaderMap = new LoaderMapClass();

/** @constructor */
var Loader = function(name, url, callbackName) {
Expand Down