-
Notifications
You must be signed in to change notification settings - Fork 1
refactor: Make Pandas optional #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Unfortunately, performance is quite important (at least for my usecase). Where is the large increase in runtime coming from? |
I assume copying the changed values from Pandas into lists/dicts.
If we want to keep one
|
I would vote for option 2 in that case |
I introduced two versions of the dataclasses: one with Pandas (to make sure the performance of @DominikZuercherQC You can decide whether you want the PolarsComparator to use the |
Thanks @AaronTacke. I guess I will create a polars version of the |
@DominikZuercherQC feel free to review this, I think it should be fine :) |
Motivation
We want Pandas to be an optional dependency, especially once a Polars Comparator (see #15) will be added.
Changes
Use native python data structures to replace Pandas in the parts of the comparator implementation that are used by multiple comparators.
TODOS
pixi.toml
)?_values
in tabulardelta_dataclasses)