Skip to content

refactor: Make Pandas optional #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

refactor: Make Pandas optional #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4596247
remove pandas from tabulardelta_dataclasses
AaronTacke Jun 7, 2025
641d33a
Remove Pandas from sqlcompyre_comparator
AaronTacke Jun 8, 2025
191b36c
Adapt tests to work without pandas
AaronTacke Jun 9, 2025
e143063
introduce dataclasses with and without pandas
AaronTacke Jun 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ jobs:
- py311
- py312
- no-sql
- no-pandas
os:
- ubuntu-22.04
- windows-latest
Expand All @@ -55,4 +56,4 @@ jobs:
- name: Install repository
run: pixi run -e ${{ matrix.environment }} postinstall
- name: Run pytest
run: pixi run -e ${{ matrix.environment }} test-coverage --color=yes ${{ matrix.environment=='no-sql' && '-m "not sql"' || ''}}
run: pixi run -e ${{ matrix.environment }} test-coverage --color=yes -m ${{ matrix.environment=='no-sql' && '"not sql"' || (matrix.environment=='no-pandas' && '"not pandas"' || '""')}}
9 changes: 5 additions & 4 deletions docs/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ For more details, please have a look at the API reference:

TabularDelta Protocol <api/tabulardelta.tabulardelta>

Comparators using TabularDelta_Dataclasses
Comparators
----------------------------------------------

Comparators can compare two (tabular) data sources and return an object which adheres to the TabularDelta protocol:
Expand All @@ -367,9 +367,10 @@ Comparators can compare two (tabular) data sources and return an object which ad
def compare(self, old: T, new: T) -> TabularDelta: ...


All current comparators rely on
:doc:`tabulardelta_dataclasses.py<api/tabulardelta.comparators.tabulardelta_dataclasses>`
which implements the TabularDelta protocol using dataclasses.
SQL-based comparators rely on
:doc:`tabulardelta_dataclasses.py<api/tabulardelta.comparators.native_dataclasses>`
while the PandasComparator uses a pandas-specific :doc:`tabulardelta_dataclasses.py<api/tabulardelta.comparators.pandas_dataclasses>`,
both of which implement the TabularDelta protocol.

These currently implemented Comparators are:

Expand Down
3,124 changes: 1,738 additions & 1,386 deletions pixi.lock
View file
Open in desktop

Large diffs are not rendered by default.

11 changes: 7 additions & 4 deletions pixi.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ postinstall = "pip install --no-build-isolation --no-deps --disable-pip-version-

[dependencies]
python = ">=3.11"
numpy = ">=1.24.4,<3"
pandas = ">=2.0.3,<3"

[host-dependencies]
pip = "*"
Expand Down Expand Up @@ -71,9 +69,14 @@ sqlalchemy = "*"
sqlcompyre = "*"
pyodbc = "*"

[feature.pandas.dependencies]
numpy = ">=1.24.4,<3"
pandas = ">=2.0.3,<3"

[environments]
no-sql = ["test"]
default = ["test", "sql"]
default = ["test", "pandas", "sql"]
no-sql = ["test", "pandas"]
no-pandas = ["test", "sql"]
py311 = ["py311", "test", "sql"]
py312 = ["py312", "test", "sql"]
docs = ["docs", "sql"]
Expand Down
Loading
Loading