Skip to content

chore(iOS): Cleanup AppDelegate #6559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2025
Merged

chore(iOS): Cleanup AppDelegate #6559

merged 1 commit into from
Aug 15, 2025

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Aug 13, 2025 •
edited
Loading

Proposed changes

Cleanup leftovers on AppDelegate from #6478

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-968

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello had a problem deploying to official_android_build August 13, 2025 18:02 — with GitHub Actions Error
@diegolmello diegolmello had a problem deploying to experimental_ios_build August 13, 2025 18:02 — with GitHub Actions Error
@diegolmello diegolmello had a problem deploying to experimental_android_build August 13, 2025 18:02 — with GitHub Actions Error
@diegolmello diegolmello marked this pull request as ready for review August 13, 2025 18:02
OtavioStasiak
OtavioStasiak approved these changes Aug 15, 2025
View reviewed changes
Copy link
Contributor

@OtavioStasiak OtavioStasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@diegolmello diegolmello force-pushed the chore.app-delegate-cleanup branch from 9327217 to db1e4a9 Compare August 15, 2025 18:50
@diegolmello diegolmello merged commit e589735 into develop Aug 15, 2025
4 of 7 checks passed
@diegolmello diegolmello deleted the chore.app-delegate-cleanup branch August 15, 2025 18:51
@diegolmello diegolmello had a problem deploying to official_android_build August 15, 2025 18:55 — with GitHub Actions Failure
@diegolmello diegolmello had a problem deploying to experimental_ios_build August 15, 2025 18:55 — with GitHub Actions Failure
@diegolmello diegolmello had a problem deploying to experimental_android_build August 15, 2025 18:55 — with GitHub Actions Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OtavioStasiak OtavioStasiak OtavioStasiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diegolmello @OtavioStasiak