Skip to content

chore(iOS): Cleanup AppDelegate #6559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

chore(iOS): Cleanup AppDelegate #6559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions ios/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import WatchConnectivity
public class AppDelegate: ExpoAppDelegate {
var window: UIWindow?

// var reactNativeDelegate: ExpoReactNativeFactoryDelegate?
var reactNativeDelegate: ReactNativeDelegate?
var reactNativeFactory: RCTReactNativeFactory?
var watchConnection: WatchConnection?
Expand All @@ -33,7 +32,6 @@ public class AppDelegate: ExpoAppDelegate {
ReplyNotification.configure()

let delegate = ReactNativeDelegate()
// let factory = ExpoReactNativeFactory(delegate: delegate)
let factory = RCTReactNativeFactory(delegate: delegate)
delegate.dependencyProvider = RCTAppDependencyProvider()

Expand Down Expand Up @@ -98,23 +96,6 @@ public class AppDelegate: ExpoAppDelegate {
}
}

//class ReactNativeDelegate: ExpoReactNativeFactoryDelegate {
// // Extension point for config-plugins
//
// override func sourceURL(for bridge: RCTBridge) -> URL? {
// // needed to return the correct URL for expo-dev-client.
// bridge.bundleURL ?? bundleURL()
// }
//
// override func bundleURL() -> URL? {
//#if DEBUG
// return RCTBundleURLProvider.sharedSettings().jsBundleURL(forBundleRoot: ".expo/.virtual-metro-entry")
//#else
// return Bundle.main.url(forResource: "main", withExtension: "jsbundle")
//#endif
// }
//}

class ReactNativeDelegate: RCTDefaultReactNativeFactoryDelegate {
override func sourceURL(for bridge: RCTBridge) -> URL? {
self.bundleURL()
Expand Down
Loading