Skip to content

Conversation

@VCLanNguyen
Copy link
Contributor

@VCLanNguyen VCLanNguyen commented Aug 30, 2025

New Standard Record Classes to Store Timing Correction in SBND Data.
Full description can be found in docdb: https://sbn-docdb.fnal.gov/cgi-bin/sso/RetrieveFile?docid=43090

Required by the following PRs:
sbnobj 2025A: SBNSoftware/sbnobj#141
sbnanaobj 2025A: #155
sbndcode 2025A: SBNSoftware/sbndcode#803
sbncode 2025A: SBNSoftware/sbncode#563

Copy link
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many comments are similar to the PR on sbnobj.

Also, I suggest caf::SBNDTimingInfo to be renamed into something like caf::DetTimingInfo or equivalent.
Most of its content (trigger, RWM, beam, TPC time) can be implemented also for ICARUS (there is probably part of that information already somewhere, but it's better to have it all in the same place for both detectors).
If and when ICARUS will implement that, we'll also update the comments.

@VCLanNguyen
Copy link
Contributor Author

Many comments are similar to the PR on sbnobj.

Also, I suggest caf::SBNDTimingInfo to be renamed into something like caf::DetTimingInfo or equivalent. Most of its content (trigger, RWM, beam, TPC time) can be implemented also for ICARUS (there is probably part of that information already somewhere, but it's better to have it all in the same place for both detectors). If and when ICARUS will implement that, we'll also update the comments.

Not sure if it applies to ICARUS. A lot of these timestamps are from SBND-specific hardware i.e. (1) timestamps recorded by SPEC-TDC and (2) High Level Trigger made by Penn Trigger Board.

Copy link
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be still a spurious class version of caf::StandardRecord.

@PetrilloAtWork PetrilloAtWork self-requested a review September 4, 2025 00:42
Copy link
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!!!

@kjplows
Copy link
Contributor

kjplows commented Sep 4, 2025

trigger build ci_ref=v10_06_02 LArSoft/larsoft@LARSOFT_SUITE_v10_06_00_02 LArSoft/larwirecell@LARSOFT_SUITE_v10_06_00_02 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbn*@release/SBN2025A SBNSoftware/sbndcode@v10_06_03

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows merged commit fb88ee6 into release/SBN2025A Sep 5, 2025
3 of 6 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in PR archaeology Jan 16, 2026
@kjplows kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026
@kjplows kjplows added this to the SBN2025A/v10_06_00_05 milestone Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change enhancement New feature or request

Projects

Status: Done
Status: 2025 PRs

Development

Successfully merging this pull request may close these issues.

6 participants