-
Notifications
You must be signed in to change notification settings - Fork 14
Frame Shift Module to Correct Timing in Data - PR For Spring Production #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PetrilloAtWork
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many comments are similar to the PR on sbnobj.
Also, I suggest caf::SBNDTimingInfo to be renamed into something like caf::DetTimingInfo or equivalent.
Most of its content (trigger, RWM, beam, TPC time) can be implemented also for ICARUS (there is probably part of that information already somewhere, but it's better to have it all in the same place for both detectors).
If and when ICARUS will implement that, we'll also update the comments.
Not sure if it applies to ICARUS. A lot of these timestamps are from SBND-specific hardware i.e. (1) timestamps recorded by SPEC-TDC and (2) High Level Trigger made by Penn Trigger Board. |
…NSoftware/sbnanaobj into lnguyen/frame_shift_pr_spring
PetrilloAtWork
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be still a spurious class version of caf::StandardRecord.
PetrilloAtWork
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!!!
|
trigger build ci_ref=v10_06_02 LArSoft/larsoft@LARSOFT_SUITE_v10_06_00_02 LArSoft/larwirecell@LARSOFT_SUITE_v10_06_00_02 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbn*@release/SBN2025A SBNSoftware/sbndcode@v10_06_03 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
New Standard Record Classes to Store Timing Correction in SBND Data.
Full description can be found in docdb: https://sbn-docdb.fnal.gov/cgi-bin/sso/RetrieveFile?docid=43090
Required by the following PRs:
sbnobj 2025A: SBNSoftware/sbnobj#141
sbnanaobj 2025A: #155
sbndcode 2025A: SBNSoftware/sbndcode#803
sbncode 2025A: SBNSoftware/sbncode#563