Skip to content

Conversation

@VCLanNguyen
Copy link
Contributor

@VCLanNguyen VCLanNguyen commented Aug 30, 2025

Description

New module for timing reconstruction. Module make data products for downstream reconstruction.
Add to reco2 workflow
Description can be found in docdb: https://sbn-docdb.fnal.gov/cgi-bin/sso/RetrieveFile?docid=43090

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{red}\bf{\textrm{IMPORTANT UPDATE June 22nd 2025:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production (which started in Spring 2025), you must make two PRs: one for develop and one for the production/v10_06_00 branch.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
sbnobj 2025A: SBNSoftware/sbnobj#141
sbnanaobj 2025A: SBNSoftware/sbnanaobj#155
sbndcode 2025A: #803
sbncode 2025A: SBNSoftware/sbncode#563

Link(s) to docdb describing changes (optional)

https://sbn-docdb.fnal.gov/cgi-bin/sso/RetrieveFile?docid=43090

@VCLanNguyen VCLanNguyen marked this pull request as ready for review August 30, 2025 00:53
Copy link
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a review, but since I had to read this code for the other reviews, I have left a comment.

@nathanielerowe
Copy link
Contributor

@PetrilloAtWork since the sbncode PR has been approved, is this one good to go as well or does it need additional changes?

@nathanielerowe
Copy link
Contributor

@JosiePaton Could you take a look at this?

@nathanielerowe
Copy link
Contributor

trigger build ci_ref=v10_06_00_03 LArSoft/larcore@LARSOFT_SUITE_v10_06_00 LArSoft/larcorealg@LARSOFT_SUITE_v10_06_00 LArSoft/larcoreobj@LARSOFT_SUITE_v10_06_00 LArSoft/lardataalg@LARSOFT_SUITE_v10_06_00 LArSoft/lardataobj@LARSOFT_SUITE_v10_06_00 LArSoft/larfinder@LARSOFT_SUITE_v10_06_00 LArSoft/larsoftobj@LARSOFT_SUITE_v10_06_00 LArSoft/larvecutils@LARSOFT_SUITE_v10_06_00 LArSoft/larpandoracontent@LARSOFT_SUITE_v10_06_00 LArSoft/larpandoracontent@LARSOFT_SUITE_v10_06_00 LArSoft/lar*@LARSOFT_SUITE_v10_06_00_02 SBNSoftware/sbncode@v10_06_00_05 SBNSoftware/sbnalg@v10_06_00_04 SBNSoftware/sbnobj@v10_01_01_01 SBNSoftware/sbnanaobj@v10_00_05_01 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbndata@v01_07 SBNSoftware/sbndutil@v10_06_00_02 SBNSoftware/sbnd_data@v01_35_00

@nathanielerowe
Copy link
Contributor

trigger build ci_ref=v10_06_00_03 LArSoft/larcore@LARSOFT_SUITE_v10_06_00 LArSoft/larcorealg@LARSOFT_SUITE_v10_06_00 LArSoft/larcoreobj@LARSOFT_SUITE_v10_06_00 LArSoft/lardataalg@LARSOFT_SUITE_v10_06_00 LArSoft/lardataobj@LARSOFT_SUITE_v10_06_00 LArSoft/larfinder@LARSOFT_SUITE_v10_06_00 LArSoft/larsoftobj@LARSOFT_SUITE_v10_06_00 LArSoft/larvecutils@LARSOFT_SUITE_v10_06_00 LArSoft/larpandoracontent@LARSOFT_SUITE_v10_06_00 LArSoft/larpandoracontent@LARSOFT_SUITE_v10_06_00 LArSoft/lar*@LARSOFT_SUITE_v10_06_00_02 SBNSoftware/sbncode@v10_06_00_05 SBNSoftware/sbnalg@v10_06_00_04 SBNSoftware/sbnobj@v10_01_01_01 SBNSoftware/sbnanaobj@v10_00_05_01 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbndata@v01_07 SBNSoftware/sbndutil@v10_06_00_02 SBNSoftware/sbnd_data@v01_35_00

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Contributor

Approved!

@nathanielerowe nathanielerowe merged commit 3e1951c into production/v10_06_00 Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants