-
Notifications
You must be signed in to change notification settings - Fork 54
Frame Shift Module to Correct Timing in Data - PR For Spring Production #803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frame Shift Module to Correct Timing in Data - PR For Spring Production #803
Conversation
PetrilloAtWork
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a review, but since I had to read this code for the other reviews, I have left a comment.
|
@PetrilloAtWork since the sbncode PR has been approved, is this one good to go as well or does it need additional changes? |
|
@JosiePaton Could you take a look at this? |
|
trigger build ci_ref=v10_06_00_03 LArSoft/larcore@LARSOFT_SUITE_v10_06_00 LArSoft/larcorealg@LARSOFT_SUITE_v10_06_00 LArSoft/larcoreobj@LARSOFT_SUITE_v10_06_00 LArSoft/lardataalg@LARSOFT_SUITE_v10_06_00 LArSoft/lardataobj@LARSOFT_SUITE_v10_06_00 LArSoft/larfinder@LARSOFT_SUITE_v10_06_00 LArSoft/larsoftobj@LARSOFT_SUITE_v10_06_00 LArSoft/larvecutils@LARSOFT_SUITE_v10_06_00 LArSoft/larpandoracontent@LARSOFT_SUITE_v10_06_00 LArSoft/larpandoracontent@LARSOFT_SUITE_v10_06_00 LArSoft/lar*@LARSOFT_SUITE_v10_06_00_02 SBNSoftware/sbncode@v10_06_00_05 SBNSoftware/sbnalg@v10_06_00_04 SBNSoftware/sbnobj@v10_01_01_01 SBNSoftware/sbnanaobj@v10_00_05_01 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbndata@v01_07 SBNSoftware/sbndutil@v10_06_00_02 SBNSoftware/sbnd_data@v01_35_00 |
|
trigger build ci_ref=v10_06_00_03 LArSoft/larcore@LARSOFT_SUITE_v10_06_00 LArSoft/larcorealg@LARSOFT_SUITE_v10_06_00 LArSoft/larcoreobj@LARSOFT_SUITE_v10_06_00 LArSoft/lardataalg@LARSOFT_SUITE_v10_06_00 LArSoft/lardataobj@LARSOFT_SUITE_v10_06_00 LArSoft/larfinder@LARSOFT_SUITE_v10_06_00 LArSoft/larsoftobj@LARSOFT_SUITE_v10_06_00 LArSoft/larvecutils@LARSOFT_SUITE_v10_06_00 LArSoft/larpandoracontent@LARSOFT_SUITE_v10_06_00 LArSoft/larpandoracontent@LARSOFT_SUITE_v10_06_00 LArSoft/lar*@LARSOFT_SUITE_v10_06_00_02 SBNSoftware/sbncode@v10_06_00_05 SBNSoftware/sbnalg@v10_06_00_04 SBNSoftware/sbnobj@v10_01_01_01 SBNSoftware/sbnanaobj@v10_00_05_01 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbndata@v01_07 SBNSoftware/sbndutil@v10_06_00_02 SBNSoftware/sbnd_data@v01_35_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
Approved! |
Description
New module for timing reconstruction. Module make data products for downstream reconstruction.
Add to reco2 workflow
Description can be found in docdb: https://sbn-docdb.fnal.gov/cgi-bin/sso/RetrieveFile?docid=43090
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
sbnobj 2025A: SBNSoftware/sbnobj#141
sbnanaobj 2025A: SBNSoftware/sbnanaobj#155
sbndcode 2025A: #803
sbncode 2025A: SBNSoftware/sbncode#563
Link(s) to docdb describing changes (optional)
https://sbn-docdb.fnal.gov/cgi-bin/sso/RetrieveFile?docid=43090