Fix CorrectedOpFlash attributes #162
Conversation
gputnam
left a comment
gputnam
left a comment
There was a problem hiding this comment.
My main comment -- can you explain why you are making this into a new object in the StandardRecord, as opposed to putting these in the existing SRFlash? It seems like an unecessary complication.
|
|
||
| void SRCorrectedOpFlash::setDefault() | ||
| { | ||
| OpFlashT0 = -9999.; |
There was a problem hiding this comment.
Isn't OpFlashT0 still in another object in the CAF?
There was a problem hiding this comment.
Is another object in the CAF but is not currently accessible from the SRSlice, so there is no way of knowing the original T0 from the slice information unless it is contained in the SRCorrectedOpFlash
kjplows
moved this from Open pull requests
to Partially reviewed
in SBN software development
|
Hi @gputnam. The main reason is that SRCorrectedOpFlashes are build using charge information to correct flash attributes. This requires using flash-matching tools, which implies that not every SRFlash gets an associated SRCorrectedFlash. In fact, from all the flashes in the event, we would ideally only correct the one that coincides with the beam spill time. If we added these attributes to the SRFlash they would be empty most of the times and we would also be forced to create an SRFlash-SRSlice assns which does not exist yet. |
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_11_01 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_11_01 SBNSoftware/sbnobj#147 SBNSoftware/sbncode#584 SBNSoftware/sbndcode#834 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
Incrementing the ClassVersion to make CI build, @asanchezcastillo |
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_11_01 SBNSoftware/sbnobj#147 SBNSoftware/sbncode#584 SBNSoftware/sbndcode#834 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
github-project-automation
bot
moved this from To merge
to Done
in SBN software development
Remove CorrectedOpFlash attributes that can be found via slice-correctedopflash assns. It also changes the attributes to reflect each of the corrections separately.
Merging this PR solves #160
This PR is to be merged with
SBNSoftware/sbncode#584
SBNSoftware/sbnobj#147