Skip to content

Fix CorrectedOpFlash attributes #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kjplows merged 7 commits into from
Nov 5, 2025
Merged

Fix CorrectedOpFlash attributes #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1f1bd2a
Fix CorrectedOpFlash attributes
asanchezcastillo Sep 26, 2025
96256a5
Merge branch 'develop' into feature/acastill_lightpropagationfix
kjplows Oct 1, 2025
f63e19e
Change time units from ns to us
asanchezcastillo Oct 1, 2025
c0e25e5
Merge branch 'develop' into feature/acastill_lightpropagationfix
kjplows Oct 24, 2025
74bdfc9
Merge branch 'develop' into feature/acastill_lightpropagationfix
kjplows Nov 4, 2025
fa071d3
Update classes_def.xml
kjplows Nov 4, 2025
2cf229a
Merge branch 'develop' into feature/acastill_lightpropagationfix
kjplows Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions sbnanaobj/StandardRecord/SRCorrectedOpFlash.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,9 @@ namespace caf
void SRCorrectedOpFlash::setDefault()
{
OpFlashT0 = -9999.;
Copy link
Contributor

@gputnam gputnam Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't OpFlashT0 still in another object in the CAF?

Copy link
Contributor Author

@asanchezcastillo asanchezcastillo Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is another object in the CAF but is not currently accessible from the SRSlice, so there is no way of knowing the original T0 from the slice information unless it is contained in the SRCorrectedOpFlash

UpstreamTime_lightonly = -9999.;
UpstreamTime_tpczcorr = -9999.;
UpstreamTime_propcorr_tpczcorr = -9999.;
SliceNuScore = -9999.;
FMScore = -9999.;
NuToFLight = -9999.;
NuToFCharge = -9999.;
OpFlashT0Corrected = -9999.;
}

} // end namespace caf
Expand Down
10 changes: 4 additions & 6 deletions sbnanaobj/StandardRecord/SRCorrectedOpFlash.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,10 @@ namespace caf

/// @name Data members related to the opflash corrected time
/// @{
float OpFlashT0 { -9999. }; ///< | OpFlash Time wrt RWM time | (ns)
float UpstreamTime_lightonly { -9999. }; ///< | Nu upstream wall time reconstructed using light only | (ns)
float UpstreamTime_tpczcorr { -9999. }; ///< | Nu upstream wall time reconstructed using light and Z from tpc vertex | (ns)
float UpstreamTime_propcorr_tpczcorr { -9999. }; ///< | Nu upstream wall time reconstructed using light propagation correction from tpc information and z correction from tpc vertex | (ns)
float SliceNuScore { -9999. }; ///< | Slice Nu Score |
float FMScore { -9999. }; ///< | Flash Match Score |
float OpFlashT0 { -9999. }; ///< | OpFlash Time wrt RWM time | (us)
float NuToFLight { -9999. }; ///< | Nu ToF using light only | (us)
float NuToFCharge { -9999. }; ///< | Nu ToF Z from tpc vertex | (us)
float OpFlashT0Corrected { -9999. }; ///< | OpFlash Time wrt RWM time after light propagation corrections | (us)
/// @}

void setDefault();
Expand Down
3 changes: 2 additions & 1 deletion sbnanaobj/StandardRecord/classes_def.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,8 @@
<version ClassVersion="10" checksum="2672302824"/>
</class>

<class name="caf::SRCorrectedOpFlash" ClassVersion="13">
<class name="caf::SRCorrectedOpFlash" ClassVersion="14">
<version ClassVersion="14" checksum="2247699110"/>
<version ClassVersion="13" checksum="3257300089"/>
<version ClassVersion="12" checksum="1558889595"/>
<version ClassVersion="11" checksum="755718921"/>
Expand Down