Do not fail with invalid schema field type check.#216
Open
YooSunYoung wants to merge 2 commits intomainfrom
Open
Do not fail with invalid schema field type check.#216YooSunYoung wants to merge 2 commits intomainfrom
YooSunYoung wants to merge 2 commits intomainfrom
Conversation
janosbabik
reviewed
Mar 20, 2026
Contributor
janosbabik
left a comment
janosbabik
left a comment
There was a problem hiding this comment.
Hi @YooSunYoung , this looks good overall. However, could we switch to single-line log events and remove the markup from the logs?
Since we’re using Graylog, multi-line messages and formatting markup make readability and debugging more difficult.
If we want nicer output in the terminal, we could introduce a logger module that formats messages differently depending on the target (terminal vs. Graylog).
Contributor
Author
|
Hi @janosbabik , I figured the comment applies to all logging in general so I fixed that in a separate PR #220 . |
janosbabik
approved these changes
Mar 23, 2026
nitrosx
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the validation step and added the validation in the
validatorinstead.Related to #214