Skip to content

Update logging messages and separate dev-tools from the metadata module.#220

Open
YooSunYoung wants to merge 1 commit intorefactor-4from
fix-logging
Open

Update logging messages and separate dev-tools from the metadata module.#220
YooSunYoung wants to merge 1 commit intorefactor-4from
fix-logging

Conversation

@YooSunYoung
Copy link
Copy Markdown
Contributor

From the comments at #216 (review)

  • Remove logging configuration that potentially contains tokens or credentials
  • Remove multi-lines and markers from the logging messages
  • Use json/as_dict for dictionary-like object logging
  • Use warning instead error for non-critical errors
  • Separate developer's tools from the scicat_metadata module

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All logs from this module are only for consoles, and not meant to be streamed to graylog.
Ideally any failure in this check should block the deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants