Skip to content

deduplicate sjoin results for points on shared region boundaries whil…#85

Merged
Herald-TUOS merged 2 commits into
developfrom
82-bug-sjoin-produces-duplicate-rows-for-points-on-shared-polygon-boundaries
May 6, 2026
Merged

deduplicate sjoin results for points on shared region boundaries whil…#85
Herald-TUOS merged 2 commits into
developfrom
82-bug-sjoin-produces-duplicate-rows-for-points-on-shared-polygon-boundaries

Conversation

@Herald-TUOS
Copy link
Copy Markdown
Contributor

…e reverse geocoding

@Herald-TUOS Herald-TUOS self-assigned this May 6, 2026
Copy link
Copy Markdown

@AndrewCRichards AndrewCRichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this instead be coded with drop_duplicates? It would make the code self-documenting, whereas the purpose of the existing line is not that clear (although one could take an educated guess).

@AndrewCRichards
Copy link
Copy Markdown

...feel free to merge with drop_duplicates

@Herald-TUOS
Copy link
Copy Markdown
Contributor Author

Could this instead be coded with drop_duplicates? It would make the code self-documenting, whereas the purpose of the existing line is not that clear (although one could take an educated guess).

drop_duplicates can't use index as a subset to check for duplicates. Which means we'll have to reset index, drop duplicates and then set index, which is slower according to the following answer on StackOverflow
https://stackoverflow.com/a/34297689

@Herald-TUOS Herald-TUOS merged commit aa8867f into develop May 6, 2026
4 checks passed
@Herald-TUOS Herald-TUOS deleted the 82-bug-sjoin-produces-duplicate-rows-for-points-on-shared-polygon-boundaries branch May 6, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: sjoin produces duplicate rows for points on shared polygon boundaries

2 participants