Skip to content

deduplicate sjoin results for points on shared region boundaries whil… #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Herald-TUOS merged 2 commits into from
May 6, 2026
Merged

deduplicate sjoin results for points on shared region boundaries whil… #85

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89a62d1
deduplicate sjoin results for points on shared region boundaries whil…
Herald-TUOS May 6, 2026
3696271
add a comment to explain deduplication of reverse geocoded results
Herald-TUOS May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions geocode/utilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,8 @@ def reverse_geocode(
).to_crs(regions.crs)
regions.set_index("region_id", inplace=True)
joined = regions.sjoin(coords, how="right").to_crs(regions.crs)
# Remove coords which fall on the boundary of multiple regions by deduplicating
joined = joined[~joined.index.duplicated(keep="first")]
# Perform sjoin nearest on coords that wasn't reverse-geocoded to a region
na_geolocations = joined[joined["region_id"].isna()].copy()
if not na_geolocations.empty and max_distance is not None:
Expand Down
Loading